Stacktrace changes #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you split out the two commits into their own pull requests and branches? The 7297d06 commit looks fine and can be probably be merged in straight away, but the 37c7614 commit looks rather strange. I can't see how it can even compile. For instance, lines 58 and 59 unquote their values, but they're not inside a syntax-quote. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current stacktrace middleware improperly nests the html <body> in it's <head> tag.
Additionally, it does not include the causes of an exception, only the topmost exception frame.
These commits address both of those concerns, outputting properly nested html and including all of an exception's causes.