Stacktrace changes #15
2 participants
Could you split out the two commits into their own pull requests and branches? The 7297d06 commit looks fine and can be probably be merged in straight away, but the 37c7614 commit looks rather strange. I can't see how it can even compile. For instance, lines 58 and 59 unquote their values, but they're not inside a syntax-quote. e-parsed is defined in one function as a local variable, but used in a different function with a completely separate scope. Additionally, you reuse the same "content" id for more than one element,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The current stacktrace middleware improperly nests the html <body> in it's <head> tag.
Additionally, it does not include the causes of an exception, only the topmost exception frame.
These commits address both of those concerns, outputting properly nested html and including all of an exception's causes.