Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set character encoding for response according to 'charset' field of 'Content-Type' header #20

Closed
wants to merge 1 commit into from

Conversation

nkly
Copy link
Contributor

@nkly nkly commented Jun 12, 2011

Hello again!

This is fixed fix for my last pull request. Hope I'm doing this right.

Regards, Nick.

@weavejester
Copy link
Collaborator

Thanks for the patch. I'll try to take a look at it tonight. By the way, would it be possible for you to add this new functionality to the servlet.clj unit tests?

@nkly
Copy link
Contributor Author

nkly commented Jun 16, 2011

Oh, I'll try in a couple of days, but can't promise anything because I've just started to learn Clojure.

@weavejester
Copy link
Collaborator

Sorry for the long delay in looking at this. I've been rather swamped recently and haven't had a chance to do much programming. I'll add a test for this and merge it in this weekend.

@schnorrer
Copy link

A much needed bug correction. I spent a few hours today trying to figure out why an app generated and deployed as a .war file treats Unicode fine, but the same app launched via jetty-adapter outputs the said question marks instead of legit wide chars. A middleware workaround did well, though the patch would do the job way, way better.

@weavejester
Copy link
Collaborator

Patched with additional test. Sorry for the delay; this pull request somehow slipped out of my TODO list.

@weavejester weavejester closed this Jul 6, 2011
jaceklaskowski referenced this pull request in jaceklaskowski/ring Oct 26, 2012
Allow for the thread pool to use daemon threads.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants