New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding `caption` attribute to `Feature Row` component #1440

Closed
lmserrano opened this Issue Jan 2, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@lmserrano

lmserrano commented Jan 2, 2018

It would be nice to be able to use the caption attribute in the Feature Row component.

  • This is a question about using the theme.
  • This is a feature request.
  • I believe this to be a bug with the theme.
    • I have updated all gems with bundle update.
    • I have tested locally with bundle exec jekyll build.

Also, congratulations for all you've achieved with this theme, and thank you for all the work you've been continuously putting into it!

@mmistakes

This comment has been minimized.

Owner

mmistakes commented Jan 2, 2018

Thanks.

What would be the purpose of a caption on the feature row? Just to include a byline/credit under the image?

@lmserrano

This comment has been minimized.

lmserrano commented Jan 2, 2018

Yes, exactly. I wanted to use it to credit images similarly with what can be done with other components of your theme, without mixing it with the excerpt field.

@mmistakes

This comment has been minimized.

Owner

mmistakes commented May 15, 2018

This has been added and will be available in an upcoming release of the theme.

By adding image_caption to a feature row item you can caption the image.

feature_row:
  - image_path: assets/images/unsplash-gallery-image-1-th.jpg
    image_caption: "Image courtesy of [Unsplash](https://unsplash.com/)"
    alt: "placeholder image 1"
    title: "Placeholder 1"
    excerpt: "This is some sample content that goes here with **Markdown** formatting."

An example can be seen on this page.

luispuerto referenced this issue in luispuerto/luispuerto.net Jun 27, 2018

Add support for captioning images in feature row helper
Use `image_caption` YAML front matter to assign a caption to the feature image, Markdown is allowed.

Close #1440
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment