New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ordering of custom sidebar and author profile #388

Closed
allender opened this Issue Jul 8, 2016 · 3 comments

Comments

Projects
None yet
2 participants
@allender

allender commented Jul 8, 2016

  • This is a question about using the theme.
  • I believe this to be a bug with the theme --- not Jekyll, GitHub Pages or one of the bundled plugins.
  • This is a feature request.
  • I have updated all gems with bundle update.
  • I have tested locally with bundle exec jekyll build.

Environment informations

  • Minimal Mistakes version: 3.2.13
  • github-pages or jekyll gem version: github-pages 86
  • Operating system: Windows 10

Expected behavior

Per the docs on layouts:

ProTip: Custom sidebar content added to a post or page's YAML Front Matter will appear above the author profile if enabled with author_profile: true.

But the author profile currently shows above the custom sidebar

Steps to reproduce the behavior

Visit: https://allender.github.io/apple2emu/intro/.

You'll notice that the author information appears above the custom sidebar, contradicting the information in the docs for the theme. The fix is easy and I can submit a PR if that would be helpful

@mmistakes

This comment has been minimized.

Show comment
Hide comment
@mmistakes

mmistakes Jul 8, 2016

Owner

It's a typo. Should say that it appears "below" the author profile. It's working as intended.

Owner

mmistakes commented Jul 8, 2016

It's a typo. Should say that it appears "below" the author profile. It's working as intended.

@allender

This comment has been minimized.

Show comment
Hide comment
@allender

allender Jul 8, 2016

Sounds good. Thanks.

allender commented Jul 8, 2016

Sounds good. Thanks.

@allender allender closed this Jul 8, 2016

@mmistakes

This comment has been minimized.

Show comment
Hide comment
@mmistakes

mmistakes Jul 8, 2016

Owner

Thanks for catching it. I'll fix the docs.

On Fri, Jul 8, 2016 at 10:46 AM, Mark Allender notifications@github.com
wrote:

Sounds good. Thanks.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#388 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ABUB7RB9AQ02CBifR3PYbB2moWC7Cl8mks5qTmK-gaJpZM4JIFu2
.

Owner

mmistakes commented Jul 8, 2016

Thanks for catching it. I'll fix the docs.

On Fri, Jul 8, 2016 at 10:46 AM, Mark Allender notifications@github.com
wrote:

Sounds good. Thanks.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#388 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ABUB7RB9AQ02CBifR3PYbB2moWC7Cl8mks5qTmK-gaJpZM4JIFu2
.

sobkowiak added a commit to sobkowiak/sobkowiak.github.io-new that referenced this issue Jul 18, 2016

cjmadsen pushed a commit to cjmadsen/cjmadsen.github.io that referenced this issue Dec 7, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment