Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using title_separator: "|", page title doesn't display correctly #760

Closed
billgarrison opened this Issue Jan 9, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@billgarrison
Copy link

billgarrison commented Jan 9, 2017

  • This is a question about using the theme.
  • I believe this to be a bug with the theme --- not Jekyll, GitHub Pages or one of the bundled plugins.
  • This is a feature request.
  • I have updated all gems with bundle update.
  • I have tested locally with bundle exec jekyll build.

Environment informations

  • Minimal Mistakes version: 4.1.1
  • github-pages or jekyll gem version: Jekyll gem 3.3.1, Ruby 2.4
  • Operating system: Mac OS 10.11.6

Expected behavior

Expected to see the "|" character display as a separator in the page breadcrumb path when bookmarking in my browser. What appears instead is a blank space.

Steps to reproduce the behavior

  1. In _config.yml, add this line:
    title_separator: "|"
  2. run bundle exec jekyll serve and open browser to localhost:4000
  3. Attempt to bookmark a page in the browser.
  4. Observe that the proposed bookmark title is missing the title separator character of "|".

Interestingly, if I pick a character other than "|" as the title separator, the feature works as expected. E.g.

title_separator: "•" works
title_separator: "&&" works
title_separator: "|" :-(

@mmistakes

This comment has been minimized.

Copy link
Owner

mmistakes commented Jan 9, 2017

I haven't tested this yet, but this could be related to YAML. I know you can use | to have it preserve newlines if you do something like:

stats: |
  65 Home Runs
  0.278 Batting Average

Perhaps it's ignoring | when parsing the YAML, which could explain why it's blank. If thats's the case maybe there is a way to escape that character so it shows up. I'd suggest digging into the YAML spec as this appears to be an issue there and not with the theme.

@mmistakes

This comment has been minimized.

Copy link
Owner

mmistakes commented Jan 10, 2017

Did some testing and it does seem like YAML or Liquid or Jekyll is removing the vertical pipe |. What you can do instead is declare it as a HTML entity and then it'll work.

title_separator: "|"

Will give you something like:

<title>Welcome to Jekyll | Minimal Mistakes</title>

@mmistakes mmistakes closed this Jan 10, 2017

@billgarrison

This comment has been minimized.

Copy link
Author

billgarrison commented Jan 10, 2017

@mmistakes mmistakes referenced this issue Aug 25, 2017

Closed

title_seperator not working for "|" #1201

3 of 5 tasks complete

mmistakes added a commit that referenced this issue Jan 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.