New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a plugin to read data files from gem #1131

Merged
merged 1 commit into from Aug 3, 2017

Conversation

Projects
None yet
2 participants
@ashmaroli
Contributor

ashmaroli commented Jul 19, 2017

Hello Michael,
Revisiting this again. Jekyll learnt a few new tricks since the last time I came with a proposal. It will now automatically require a theme's runtime dependencies. Ergo, the end-user doesn't have to add the required plugins to their config file.

Simply having theme: minimal-mistakes-jekyll will call the dependencies as if it were a Ruby program

With jekyll-data, users need not update their data files with the changes you make. It'll be pulled in from the theme-gem itself.
(It's a different story, if users prefer to use custom ui-text strings though)

With this PR

  • jekyll-data v1.x
  • jekyll 3.5 automatically requires a theme's runtime deps
  • jekyll v3.5.0 had bugs. Hence use v3.5.1 and beyond
Use a plugin to read data files from gem
  - jekyll-data v1.x
  - jekyll 3.5 automatically requires a theme's runtime deps
  - jekyll v3.5.0 had bugs. Hence use v3.5.1 and beyond
@mmistakes

This comment has been minimized.

Show comment
Hide comment
@mmistakes

mmistakes Jul 21, 2017

Owner

Nice! Thanks for the PR. When I get a chance I just want to give it a quick test and then I think it'll be easily merged in.

Owner

mmistakes commented Jul 21, 2017

Nice! Thanks for the PR. When I get a chance I just want to give it a quick test and then I think it'll be easily merged in.

@mmistakes mmistakes merged commit 97b37ba into mmistakes:master Aug 3, 2017

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Aug 4, 2017

Contributor

Thank you Michael 😃

Contributor

ashmaroli commented Aug 4, 2017

Thank you Michael 😃

@ashmaroli ashmaroli deleted the ashmaroli:feature/jekyll-data branch Aug 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment