Use a plugin to read data files from gem #1131
Merged
+4
−584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- jekyll-data v1.x - jekyll 3.5 automatically requires a theme's runtime deps - jekyll v3.5.0 had bugs. Hence use v3.5.1 and beyond
|
Nice! Thanks for the PR. When I get a chance I just want to give it a quick test and then I think it'll be easily merged in. |
|
Thank you Michael 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Michael,
Revisiting this again. Jekyll learnt a few new tricks since the last time I came with a proposal. It will now automatically require a theme's runtime dependencies. Ergo, the end-user doesn't have to add the required plugins to their config file.
Simply having
theme: minimal-mistakes-jekyllwill call the dependencies as if it were a Ruby programWith
jekyll-data, users need not update their data files with the changes you make. It'll be pulled in from the theme-gem itself.(It's a different story, if users prefer to use custom ui-text strings though)
With this PR