New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not print the comments form #1195

Merged
merged 3 commits into from Aug 22, 2017

Conversation

Projects
None yet
2 participants
@lsolesen
Contributor

lsolesen commented Aug 22, 2017

No description provided.

@mmistakes

This comment has been minimized.

Show comment
Hide comment
@mmistakes

mmistakes Aug 22, 2017

Owner

I'd prefer not to hide comments as they can be considered "content" in a lot of cases.

Also, the preferred method to hiding would be to add the element you'd like to hide to _sass/minimal-mistakes/_print.scss.

Owner

mmistakes commented Aug 22, 2017

I'd prefer not to hide comments as they can be considered "content" in a lot of cases.

Also, the preferred method to hiding would be to add the element you'd like to hide to _sass/minimal-mistakes/_print.scss.

@lsolesen

This comment has been minimized.

Show comment
Hide comment
@lsolesen

lsolesen Aug 22, 2017

Contributor

@mmistakes This is only hiding the comments form, not the comments themselves. I can revise to use markup instead, if you prefer.

Contributor

lsolesen commented Aug 22, 2017

@mmistakes This is only hiding the comments form, not the comments themselves. I can revise to use markup instead, if you prefer.

@mmistakes

This comment has been minimized.

Show comment
Hide comment
@mmistakes

mmistakes Aug 22, 2017

Owner

Gotcha. Yes, please add the form class to _print.scss to hide instead of adding a no-print class to the HTML.

Owner

mmistakes commented Aug 22, 2017

Gotcha. Yes, please add the form class to _print.scss to hide instead of adding a no-print class to the HTML.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment