New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ws underlying in sidebar and footer. #303

Merged
merged 1 commit into from May 13, 2016

Conversation

Projects
None yet
2 participants
@tobie
Contributor

tobie commented May 3, 2016

Small fix to avoid underlying the whitespace between icons and related text when hovering.

@mmistakes

This comment has been minimized.

Show comment
Hide comment
@mmistakes

mmistakes May 4, 2016

Owner

Only drawback here is the icon is no longer linked... which I preferred. I think a better fix is adjusting the styling on the .fa class. What's going on is Font Awesome has some default styles to display icons as inline-block which removes the underline on hover. Simply doing:

.social-icons {
  .fa {
    display: initial;
  }
}

Underlines the entire link properly.

mm-author-link-hover

Owner

mmistakes commented May 4, 2016

Only drawback here is the icon is no longer linked... which I preferred. I think a better fix is adjusting the styling on the .fa class. What's going on is Font Awesome has some default styles to display icons as inline-block which removes the underline on hover. Simply doing:

.social-icons {
  .fa {
    display: initial;
  }
}

Underlines the entire link properly.

mm-author-link-hover

@tobie

This comment has been minimized.

Show comment
Hide comment
@tobie

tobie May 4, 2016

Contributor

That's… frustratingly simpler. :D

Contributor

tobie commented May 4, 2016

That's… frustratingly simpler. :D

@tobie

This comment has been minimized.

Show comment
Hide comment
@tobie

tobie May 5, 2016

Contributor

Fixed it. LMK if that's what you had in mind.

Contributor

tobie commented May 5, 2016

Fixed it. LMK if that's what you had in mind.

@mmistakes mmistakes merged commit 9582a1b into mmistakes:master May 13, 2016

@mmistakes

This comment has been minimized.

Show comment
Hide comment
@mmistakes

mmistakes May 13, 2016

Owner

Thanks for the PR @tobie!

Owner

mmistakes commented May 13, 2016

Thanks for the PR @tobie!

@tobie tobie deleted the tobie:fix-ws branch Jul 30, 2016

@tobie

This comment has been minimized.

Show comment
Hide comment
@tobie

tobie Jul 30, 2016

Contributor

This resurfaced as an issue. Not sure what happened.

Contributor

tobie commented Jul 30, 2016

This resurfaced as an issue. Not sure what happened.

@mmistakes

This comment has been minimized.

Show comment
Hide comment
@mmistakes

mmistakes Jul 30, 2016

Owner

If I remember correctly display: initial that originally fixed the underline issue was causing problems with the icon alignment... they weren't exactly centered.

As part of #341 I reverted it back. Not sure if there's another way to do it so the underline is correct and the alignment as well. Personally I'd prefer the alignment since you only see the small missing bit of underline on hover (something you'll never notice on a lot of devices eg: touch enabled ones).

Happy to accept another PR if there's a way to solve it for both.

Owner

mmistakes commented Jul 30, 2016

If I remember correctly display: initial that originally fixed the underline issue was causing problems with the icon alignment... they weren't exactly centered.

As part of #341 I reverted it back. Not sure if there's another way to do it so the underline is correct and the alignment as well. Personally I'd prefer the alignment since you only see the small missing bit of underline on hover (something you'll never notice on a lot of devices eg: touch enabled ones).

Happy to accept another PR if there's a way to solve it for both.

@tobie

This comment has been minimized.

Show comment
Hide comment
@tobie

tobie Jul 30, 2016

Contributor

I unfortunately don't have the CSS chops to fix this, so I guess I'll have to live with it. :)

Contributor

tobie commented Jul 30, 2016

I unfortunately don't have the CSS chops to fix this, so I guess I'll have to live with it. :)

Manu343726 pushed a commit to Manu343726/Manu343726.github.io that referenced this pull request Sep 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment