Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

javascript to embed comments from discourse forum #335

Merged
merged 2 commits into from
Jun 3, 2016
Merged

javascript to embed comments from discourse forum #335

merged 2 commits into from
Jun 3, 2016

Conversation

rriemann
Copy link
Contributor

@rriemann rriemann commented Jun 2, 2016

The comment system can be changed to embed topics from the Discourse
forum software: http://discourse.org/

More details: https://meta.discourse.org/t/embedding-discourse-comments-via-javascript/31963

The comment system can be changed to embed topics from the Discourse
forum software: http://discourse.org/

More details: https://meta.discourse.org/t/embedding-discourse-comments-via-javascript/31963
@@ -0,0 +1,13 @@
{% if site.comments.discourse.server %}
{% capture canonical %}{{ site.url }}{% if site.permalink contains '.html' %}{{ page.url }}{% else %}{{ page.url | remove:'index.html' | strip_slash }}{% endif %}{% endcapture %}
Copy link
Owner

@mmistakes mmistakes Jun 3, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to add {{ site.baseurl }} after {{ site.url }} as the theme supports that and if defined in _config.yml will probably assign the wrong page url to canonical.

@rriemann
Copy link
Contributor Author

rriemann commented Jun 3, 2016

Ok, I reuse the base_path snippet.

@mmistakes
Copy link
Owner

@rriemann I've never setup Discourse before. Are the resoruces on https://meta.discourse.org/t/embedding-discourse-comments-via-javascript/31963 all that someone needs to get up and running? I want to be sure I include all the relevant info in the theme's docs because I know I'll get support issues about it eventually 😉.

@rriemann
Copy link
Contributor Author

rriemann commented Jun 3, 2016

Yes, it should be fine. The Discourse meta forum is a great place to figure out
problems and if there is a problem at some point, the provided link is not
only the right place to find some advice, but also to ask questions.

On Friday 03 June 2016 07:45:53 Michael Rose wrote:

@rriemann I've never setup Discourse before. Are the resoruces on
https://meta.discourse.org/t/embedding-discourse-comments-via-javascript/31
963 all that someone needs to get up and running? I want to be sure I
include all the relevant info in the theme's docs because I know I'll get
support issues about it eventually 😉.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#335 (comment)
5

@mmistakes mmistakes merged commit e186ee3 into mmistakes:master Jun 3, 2016
@rriemann rriemann deleted the feature-discourse-comments branch June 5, 2016 11:45
cjmadsen pushed a commit to cjmadsen/cjmadsen.github.io that referenced this pull request Dec 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants