New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open Graph Image Tag for Header Overlay Images #358

Merged
merged 1 commit into from Jun 13, 2016

Conversation

Projects
None yet
2 participants
@jhabdas
Contributor

jhabdas commented Jun 12, 2016

Add Open Graph Image tag if page.header.overlay_image is used. Additionally, fix a casing issue in the theme's generated microdata.

@jhabdas jhabdas changed the title from Use header overlay images for Open Graph image to Open Graph Image Tag for Header Overlay Images Jun 13, 2016

@@ -113,7 +115,7 @@
<script type="application/ld+json">
{
"@context" : "http://schema.org",
"@type" : "{% if site.social.type %}{{ site.social.type }}{% else %}person{% endif %}",
"@type" : "{% if site.social.type %}{{ site.social.type }}{% else %}Person{% endif %}",

This comment has been minimized.

@mmistakes

mmistakes Jun 13, 2016

Owner

Actually per the schema spec I believe this is suppose to be capitalized.

jekyll-seo-tag suggests the capitalized version as well.

type - The type of things that the page represents. This must be a Schema.org type, and will probably usually be something like BlogPosting, NewsArticle, Person, Organization, etc.

@mmistakes

mmistakes Jun 13, 2016

Owner

Actually per the schema spec I believe this is suppose to be capitalized.

jekyll-seo-tag suggests the capitalized version as well.

type - The type of things that the page represents. This must be a Schema.org type, and will probably usually be something like BlogPosting, NewsArticle, Person, Organization, etc.

This comment has been minimized.

@jhabdas

jhabdas Jun 13, 2016

Contributor

Thanks for the background. I noticed it should be capitalized it after seeing feedback from https://webmaster.yandex.com/microtest.xml.

@jhabdas

jhabdas Jun 13, 2016

Contributor

Thanks for the background. I noticed it should be capitalized it after seeing feedback from https://webmaster.yandex.com/microtest.xml.

Show outdated Hide outdated _includes/seo.html
@jhabdas

This comment has been minimized.

Show comment
Hide comment
@jhabdas

jhabdas Jun 13, 2016

Contributor

Made a small update to change http to :// to match recent changes and updated with master. Confirmed overlay images are now pulling through to share widget as pictured below:

screen shot 2016-06-13 at 11 16 36 am

Contributor

jhabdas commented Jun 13, 2016

Made a small update to change http to :// to match recent changes and updated with master. Confirmed overlay images are now pulling through to share widget as pictured below:

screen shot 2016-06-13 at 11 16 36 am

@mmistakes mmistakes merged commit beaaa88 into mmistakes:master Jun 13, 2016

@mmistakes

This comment has been minimized.

Show comment
Hide comment
@mmistakes

mmistakes Jun 13, 2016

Owner

Thanks sir.

Owner

mmistakes commented Jun 13, 2016

Thanks sir.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment