Open Graph Image Tag for Header Overlay Images #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
changed the title
| @@ -113,7 +115,7 @@ | |||
| <script type="application/ld+json"> | |||
| { | |||
| "@context" : "http://schema.org", | |||
| "@type" : "{% if site.social.type %}{{ site.social.type }}{% else %}person{% endif %}", | |||
| "@type" : "{% if site.social.type %}{{ site.social.type }}{% else %}Person{% endif %}", | |||
There was a problem hiding this comment.
Actually per the schema spec I believe this is suppose to be capitalized.
jekyll-seo-tag suggests the capitalized version as well.
type- The type of things that the page represents. This must be a Schema.org type, and will probably usually be something likeBlogPosting,NewsArticle,Person,Organization, etc.
There was a problem hiding this comment.
Thanks for the background. I noticed it should be capitalized it after seeing feedback from https://webmaster.yandex.com/microtest.xml.
|
Made a small update to change
|
|
Thanks sir. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Open Graph Image tag if
page.header.overlay_imageis used. Additionally, fix a casing issue in the theme's generated microdata.