Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Security alerts #341

Closed
orcahmlee opened this issue Aug 30, 2019 · 1 comment
Closed

Security alerts #341

orcahmlee opened this issue Aug 30, 2019 · 1 comment
Labels
Type: Security

Comments

@orcahmlee
Copy link

Hi @mmistakes,
I got two security alerts from GitHub. I've tried using automated security fix on GitHub but it doesn't work. Could you give me some hints about how to fix these?

Screen Shot 2019-08-30 at 14 35 42
Screen Shot 2019-08-30 at 14 36 10
@mmistakes
Copy link
Owner

mmistakes commented Aug 30, 2019 •
edited
Loading

It's a minor thing, just bump onchange to 6.0 in package.json.

mmistakes/minimal-mistakes#2241

This security alert has zero affect on your actual site, it's just part of a script to build the theme's JavaScript file.

@mmistakes mmistakes mentioned this issue Oct 28, 2019
Merged
mmistakes added a commit that referenced this issue Oct 30, 2019
@mmistakes
Merge pull request #350 from mmistakes/3.2.0
e37376e 
## Added
- Add light and dark skins. [#347]
- Add support for customizable skins. [#347]

## Fixed
- Fix security alerts and update [onchange](https://www.npmjs.com/package/onchange) development dependency in `package.json`. [#341]
clarafy pushed a commit to clarafy/clarafy.github.io that referenced this issue Mar 24, 2021
@mmistakes
Update onchange development dependency in package.json
969b1ab 
Close mmistakes#341
clarafy pushed a commit to clarafy/clarafy.github.io that referenced this issue Mar 24, 2021
@mmistakes
Merge pull request mmistakes#350 from mmistakes/3.2.0
d2ccfec 
## Added
- Add light and dark skins. [mmistakes#347]
- Add support for customizable skins. [mmistakes#347]

## Fixed
- Fix security alerts and update [onchange](https://www.npmjs.com/package/onchange) development dependency in `package.json`. [mmistakes#341]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Security
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mmistakes @orcahmlee