Update dependencies - use candela for lights #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcusLongmuir
force-pushed
the
other/update-dependencies-20240421
branch
from
5ac011e
to
96a24c4
Compare
TheCodeTherapy
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates multiple dependencies, but most importantly updates THREE.js to
0.163.0and in THREE.jsv0.155.0there was a change to use candela to specify lighting intensities.The MML spec (XSD) is also updated in this PR to specify that lights are measured in candela.
This required multiplying existing
intensityvalues that are in the e2e tests and rebuilding the e2e test images.What kind of changes does your PR introduce? (check at least one)
Does your PR introduce a breaking change? (check one)
If yes, please describe its impact and migration path for existing applications:
MML content targeting this version of the spec will need to update
m-lightintensityvalues.Does your PR fulfill the following requirements?