adds a 'cast-shadow' attribute to m-light to toggle shadow casting #167
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a
cast-shadow
boolean attribute to the<m-light>
tag to allow the user to enable (default) or disable shadow casting for them-lights
in an MML document.MML uses ThreeJS on
mml-web
, and ThreeJS uses shadow maps by default. That means having more than 15 lights casting shadows on a scene will likely exceed the number of texture units available for the WebGL context. Even when not exceeding the limit, a high number of shadow-casting lights with shadow maps impose a brutal performance impact (as every light casting shadows must draw every object in the scene from its own perspective to draw the shadows, and finally the renderer needs an extra draw call to blend all the shadow maps).What kind of changes does your PR introduce? (check at least one)
Does your PR introduce a breaking change? (check one)
If yes, please describe its impact and migration path for existing applications:
Does your PR fulfill the following requirements?