Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

m-audio loop-duration (#174) #175

Merged
merged 2 commits into from
Jun 12, 2024
Merged

m-audio loop-duration (#174) #175

merged 2 commits into from
Jun 12, 2024

Conversation

MarcusLongmuir
Copy link
Collaborator

@MarcusLongmuir MarcusLongmuir commented Jun 7, 2024

Resolves #174.

This PR:

  • adds a loop-duration attribute to m-audio

    The duration in seconds of the audio loop if loop is true. Can be shorter or longer than the audio file duration. Durations longer than the audio file will add silence. If not specified, the entire audio file will loop.

  • refactors the m-audio audio playback to use the WebAudio API rather than an <audio> tag. This was necessary to allow precise timing of (re)starting playback when the loop duration was longer than the provided file.


What kind of changes does your PR introduce? (check at least one)

  • Feature

Does your PR introduce a breaking change? (check one)

  • No

If yes, please describe its impact and migration path for existing applications:

Does your PR fulfill the following requirements?

  • All tests are passing
  • The title references the corresponding issue # (if relevant)

@TheCodeTherapy TheCodeTherapy merged commit 5cac31d into main Jun 12, 2024
8 checks passed
@TheCodeTherapy TheCodeTherapy deleted the feature/loop-duration branch June 12, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

m-audio loop-duration
2 participants