Fix memory leak in m-frame loading progress (#178) #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #178.
The removal of loading progress of static
m-frames was being reported to the wrongLoadingProgressManager. It should have been being reported to the parentLoadingProgressManager, but was instead reported to its own. This meant that the parentLoadingProgressManagerwas retaining a reference to them-frameelement which was preventing it from being garbage collected.There are also two minor drive-by fixes that were found during investigation that prevent holding references to previous instance data.
cc @tbergmueller
What kind of changes does your PR introduce? (check at least one)
Does your PR introduce a breaking change? (check one)
Does your PR fulfill the following requirements?