adds the emissive attribute to the m-video element #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -232,6 +240,11 @@ export class Video extends TransformableElement { | |||
| const video = document.createElement("video"); | |||
| const material = this.mesh.material; | |||
| const videoTexture = new THREE.VideoTexture(video); | |||
| if (this.props.emissive > 0) { | |||
There was a problem hiding this comment.
I think we should use the same code to apply the emissiveness changes on both attribute update and when the material is initially created here (the code here ~matches updateMaterialEmissiveIntensity)
| @@ -246,6 +254,9 @@ export class Video extends TransformableElement { | |||
| material, | |||
| videoTexture, | |||
| }; | |||
| if (this.props.emissive > 0) { | |||
There was a problem hiding this comment.
I think you can remove this condition to make it clearer that the side-effects on the material can be applied either way
MarcusLongmuir
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
emissiveattribute for the<m-video>tag onmml-web. This allows the user to specify the emissive strength of the video (how much perceived light it will emit).What kind of changes does your PR introduce? (check at least one)
Does your PR introduce a breaking change? (check one)
If yes, please describe its impact and migration path for existing applications:
Does your PR fulfill the following requirements?
2024-07-04.15-23-07.mp4