Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import files #112

Closed
EGA-man opened this issue May 3, 2022 · 11 comments
Closed

Import files #112

EGA-man opened this issue May 3, 2022 · 11 comments
Labels
enhancement New feature or request

Comments

@EGA-man
Copy link

EGA-man commented May 3, 2022

It's cool to have all the music in Chip Player JS available, but there's just some tunes that won't be able to be played. That's why I think it should have an option to import files like .nsf, .mid, .spc, .sf2, all that jazz.

@mmontag
Copy link
Owner

mmontag commented Oct 7, 2022

you can drag and drop files from your computer to play them as needed (even .sf2 now).
Or do you want Chip Player to remember your local files somehow?

@polygonnedpotato
Copy link

Or do you want Chip Player to remember your local files somehow?

implementing this through either firebase or IndexedDB would actually be a great idea and a great timesaver.

@jadasse
Copy link

jadasse commented Oct 13, 2022

Or do you want Chip Player to remember your local files somehow?

implementing this through either firebase or IndexedDB would actually be a great idea and a great timesaver.

yea

@mmontag mmontag added the enhancement New feature or request label Oct 13, 2022
@mmontag
Copy link
Owner

mmontag commented Oct 13, 2022

Sounds like a cool idea, hopefully I can do this soon.
BTW, what are these cool files that I'm missing from the catalog? 🙂

@jadasse
Copy link

jadasse commented Oct 13, 2022

Sounds like a cool idea, hopefully I can do this soon.

BTW, what are these cool files that I'm missing from the catalog? 🙂

I think he means files from local drives, not coming with the catalog.

@jadasse
Copy link

jadasse commented Oct 17, 2022

Also, can it be added as a button prompt? Apparently, drag-and-drop doesn't work in some cases.

@GunGunGun
Copy link

Sounds like a cool idea, hopefully I can do this soon. BTW, what are these cool files that I'm missing from the catalog? 🙂

A lot honestly, the world of midi is vast, try some godtier RPG music from https://d-symphony.com/mt_00.html.

Also, the drag & drop feature can only add 1 music at a time, even if I drag 100 midi files Chip Player only plays the 1st song and ignore that rest, would be great if that can be improved.

@mmontag
Copy link
Owner

mmontag commented May 4, 2024

Thanks @GunGunGun, these are really cool.
I am always interested to find collections of curated MIDI music in case you know of more like this.

The issue with dragging multiple files is that it will need new UI to display the list. Maybe another tab for Local/Imported files.
It might not be possible to create a folder structure there.

mmontag added a commit that referenced this issue May 24, 2024
One of the biggest additions to App component in a long time.
From about 860 to 950 lines. Mostly in updates to file drop handler.
@mmontag
Copy link
Owner

mmontag commented May 24, 2024

Hey all, I added a Local Files tab - Chip Player JS will now keep track of local files you dragged, using the IndexedDB (via Emscripten filesystem API).

You can drag multiple files at once - if some of them are not song files, they will be ignored.

Behavior has changed slightly; the song won't play immediately when you drag a file. You have to click on it. It will be added to the bottom of the Local Files list.

@jadasse I will try to add a button prompt here too, but if you can post some details about which browser/platform doesn't work with drag & drop, that would be awesome.

@mmontag
Copy link
Owner

mmontag commented May 24, 2024

I'm going to close this one, so if you spot some bugs please file a new issue!

@mmontag mmontag closed this as completed May 24, 2024
@GunGunGun
Copy link

Hey all, I added a Local Files tab - Chip Player JS will now keep track of local files you dragged, using the IndexedDB (via Emscripten filesystem API).

You can drag multiple files at once - if some of them are not song files, they will be ignored.

Behavior has changed slightly; the song won't play immediately when you drag a file. You have to click on it. It will be added to the bottom of the Local Files list.

@jadasse I will try to add a button prompt here too, but if you can post some details about which browser/platform doesn't work with drag & drop, that would be awesome.

Great job, this is such a huge quality of life, I'll definitely test and report if there's errors!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants