Very small change to pavlov for Windows compatibilty #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ows line endings in javascript files
|
Thanks! That little patch just fixed my problem. :) |
|
Glad it helped someone other than myself :0) |
|
Paul, thanks so much for your patch, which I've finally merged. I'm ashamed it has taken me this long to finally apply it, but I definitely appreciate the fix! |
|
Glad to help :0) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Michael,
I have been experimenting with your excellent library on Windows and had a little trouble with one of the regular expressions not working with files I was developing because it expected *nix line endings rather than Windows in the javascript files.
I think the intention of the expression was to grab the content of the function regardless of any kind of white-space; so changed it to /s from /n.
Cheers,
Paul