Some more assertions, various tweaks #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since JsTestDriver does not allow commas in test names this 'quick-n-dirty' fix is required to allow Pavlov to work in a JsTestDriver environment. Note: a more sensible approach would be to fix JsTestDriver to not place restrictions on test names but this seems to be way harder to fix. Signed-off-by: Isak Bakken <isak@klarna.com>
Signed-off-by: Isak Bakken <isak@klarna.com>
Signed-off-by: Isak Bakken <isak@klarna.com>
|
Please note that in my fork of https://github.com/pandell/pavlov/network
Current state of master branch:
My point is that if you are ok with my changes, you can just fast-forward your master branch to my master branch and effectively accept all three pull requests with one strike 😉. |
|
Very nice @milang! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NB: Changes to assertions might not be 100% backward-compatible.
Also note that in my repo's readme the repo path is changed, and the version have been bumped.