Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Bug #5 #6

Merged
merged 5 commits into from
Mar 29, 2011
Merged

Fix for Bug #5 #6

merged 5 commits into from
Mar 29, 2011

Conversation

edelabar
Copy link
Contributor

Easier than I expected to fix, the code is very readable! I want to get a test together in true TDD fashion, but I'm still trying to wrap my head around unit tests for Pavlov written in Pavlov...until then, this fixes the case that I specified in the bug report.

@mmonteleone
Copy link
Owner

Thanks for this! I'm about to merge it after I can figure out a decent test. There was already a test to for the 'Not Implemented' spec stubbing feature in pavlov.specs.js called should generate a failing (todo) test when not passed a lambda, but apparently it was a bad test, as it didn't catch what I think may have been a QUnit-change-related scoping regression in Pavlov.

@mmonteleone mmonteleone merged commit 3c74d47 into mmonteleone:master Mar 29, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants