Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dune rules #31

Merged
merged 1 commit into from
Mar 30, 2021
Merged

Fix dune rules #31

merged 1 commit into from
Mar 30, 2021

Conversation

rgrinberg
Copy link
Contributor

  • Add gsl_include.sexp when running do_sf.exe
  • Fix formatting of dune rules
  • Simplify rules by removing explicit dependency on exe's. Dune adds
    this dependency automatically when using run.

* Add gsl_include.sexp when running do_sf.exe
* Fix formatting of dune rules
* Simplify rules by removing explicit dependency on exe's. Dune adds
this dependency automatically when using `run`.

Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
@mmottl
Copy link
Owner

mmottl commented Mar 30, 2021

Thanks, I'll make a new release!

@rgrinberg rgrinberg deleted the fix-rules branch March 30, 2021 21:46
@mmottl
Copy link
Owner

mmottl commented Mar 30, 2021

@rgrinberg Btw., would there be any significant difference between these two lines:

(action (run ./foo.exe))
(action (run foo.exe))

If not, I'll use the shorter version in my packages.

@rgrinberg
Copy link
Contributor Author

rgrinberg commented Mar 30, 2021 via email

@rgrinberg
Copy link
Contributor Author

Actually, I'm wrong about that. (run foo.exe) will look it up in PATH or relative to the dune file.

@mmottl
Copy link
Owner

mmottl commented Mar 30, 2021

Ok, so I assume that the explicit path is preferred? If it's safer, I'd rather use this form.

@rgrinberg
Copy link
Contributor Author

I prefer the explicit form whenever possible for that reason

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants