Extra configurable options

[joelcox]

Hey Mike, thanks for the great module.

I've added some extra configurable options to the library, especially for PDF output. I haven't fully tested nor documented all the changes yet because I wanted your input first. I made some changes in the way arguments are parsed for greater flexibility. The options object literal now looks like this:

var options = {
    out: './tmp',
    format: 'pdf',
    viewportWidth: 915,
    viewportHeight: 768,
    paperMargin: '2mm',
    paperOrientation: 'portait',
    paperFormat: 'A4',
    phantomBin: __dirname + '/node_modules/phantomjs/bin/phantomjs'
};

[mmoulton]

Thanks Joel for the pull request. This looks great to me. If you get the tests passing I would be happy to merge it.

[joelcox]

Cool, I'll get this fixed up sometime later.

[joelcox]

I fixed the test and updated the docs. Let me know what you think.

[mmoulton]

Thank you Joel for the great contribution. I will push a new build shortly.

[joelcox]

Awesome!

On Apr 9, 2013, at 7:06 PM, Mike Moulton notifications@github.com wrote:

Thank you Joel for the great contribution. I will push a new build shortly.

—
Reply to this email directly or view it on GitHub.