Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clamping of noise octaves in Turbulence #3

Closed
bugmenot2 opened this issue Aug 26, 2010 · 1 comment
Closed

clamping of noise octaves in Turbulence #3

bugmenot2 opened this issue Aug 26, 2010 · 1 comment

Comments

@bugmenot2
Copy link

Omitting octaves essentially replaces them by the constant 0. This is only correct if the average of an octave is zero, as is the case for the Noise() function used in FBm.

But the average of the fabsf(Noise()) function used in Turbulence is non-zero. It is in fact the standard deviation of the Noise() function (roughly 0.2). Omitted octaves should be replaced by that non-zero constant or the result will be too small. In fact, if the maximum differential dpdx or dpdy > 2 (e.g. at grazing angles), the number of octaves n < 0, and the result will be black instead of gray.

@mmp
Copy link
Owner

mmp commented Aug 31, 2010

Nice one, thanks. Fix just pushed to github.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants