Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about photon power #30

Closed
2H0U opened this issue Apr 24, 2014 · 1 comment
Closed

Question about photon power #30

2H0U opened this issue Apr 24, 2014 · 1 comment

Comments

@2H0U
Copy link

2H0U commented Apr 24, 2014

In function PhotonShootingTask::Run, the photon power is initiated by function Light::Sample_L which gives radiance instead of flux. In this case, the result of function EPhoton will have a wrong unit. Any explanation?

@mmp
Copy link
Owner

mmp commented May 17, 2014

The way that photon mapping is introduced in Physically Based Rendering isn't in terms of the traditional differential flux stuff, but in terms of measurement equations (see section 15.6.1). In that framework, it actually is radiance that's emitted by the light sources.

An alternate answer would be that if you want to think about it in terms of differential flux, then it's the same computations as pbrt has implemented, just with various unit conversions happening at different times. But IMHO the PBR approach is a bit more rigorous, and also leads to a foundation that works better for understanding things like the recent vertex connection and merging work...

@mmp mmp closed this as completed May 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants