Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed Curve::Intersect() about z component. #1

Merged
merged 1 commit into from
Jun 16, 2015

Conversation

KojiNakamaru
Copy link
Contributor

This fix introduces a subexpression about z as described in Errata (http://eaflux.com/index.html.en):

Page 2, bottom right: If control points are placed non-uniformly in ray direction, the resulting v parameter may have a large margin of error because the algorithm computes v in 2D space. To compensate this, we should add a subexpression about z in the maximum depth computation. (Thanks to Emil Kirichev)

Anyway, thank you very much for implementing the algorithm!

mmp added a commit that referenced this pull request Jun 16, 2015
fixed Curve::Intersect() about z component.
@mmp mmp merged commit c826c34 into mmp:master Jun 16, 2015
@mmp
Copy link
Owner

mmp commented Jun 16, 2015

Thanks!!

DaseinPhaos added a commit to GraphiCon/pbrt-v3 that referenced this pull request May 10, 2017
update from remote master
Mx7f pushed a commit to Mx7f/pbrt-v3-1 that referenced this pull request Nov 6, 2018
Added retro material from Zhenyi.
aprotyas pushed a commit to aprotyas/pbrt-v3 that referenced this pull request Apr 26, 2022
Update environment initialization script
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants