Merged
Conversation
- obtained from https://github.com/stripe/openapi - licensed as MIT (https://github.com/stripe/openapi/blob/master/LICENSE) although this is currently missing from the specification itself (see stripe/openapi#120)
mnahkies
added a commit
that referenced
this pull request
Apr 22, 2023
the stripe definitions include schema names like: ``` checkout.session ``` which isn't a valid identifier in typescript. replace these with `_` and add tests for the `openapi-utils.ts` functions should get #49 closer to passing.
mnahkies
added a commit
that referenced
this pull request
Apr 22, 2023
the stripe definitions include schema names like: ``` checkout.session ``` which isn't a valid identifier in typescript. replace these with `_` and add tests for the `openapi-utils.ts` functions should get #49 closer to passing.
mnahkies
added a commit
that referenced
this pull request
Apr 22, 2023
the stripe definitions include schema names like: ``` checkout.session ``` which isn't a valid identifier in typescript. replace these with `_` and add tests for the `openapi-utils.ts` functions should get #49 closer to passing.
mnahkies
added a commit
that referenced
this pull request
Apr 23, 2023
- dependency graph no longer infinitely recurses - zod schemas now detect when they need to use `lazy` - joi schemas now detect when they need to use `id` / `link` required for #49
Owner
Author
|
Well it took a fair few improvements, but it seems to be generating valid code now 😄
It's still far from perfect, with the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
obtained from https://github.com/stripe/openapi
licensed as MIT (https://github.com/stripe/openapi/blob/master/LICENSE)
although this is currently missing from the specification itself
(see Add license to info block stripe/openapi#120)
generation currently broken, will add bug fixes in other PR's until it goes green