feat: better support for additional properties - #57
Merged
Conversation
- adjust normalization of additionalProperties on input to support scheamas - adjust type builder to output a union when additionalProperties is declared, where the type remains unknown when set to true, but uses the schema type otherwise - begin incremental adoption of prettier in the codebase, I've been putting it off to try and keep diff's more readable, but think it's time mostly solves #44
mnahkies
enabled auto-merge (squash)
April 23, 2023 07:54
mnahkies
added a commit
that referenced
this pull request
Apr 23, 2023
- obtained from https://github.com/stripe/openapi - licensed as MIT (https://github.com/stripe/openapi/blob/master/LICENSE) although this is currently missing from the specification itself (see stripe/openapi#120) surfaced numerous issues that are now fixed: - #50 - #55 - #56 - #57 - #58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adjust normalization of
additionalPropertieson input to supportschemas
adjust type builder to output a union when
additionalPropertiesisdeclared, where the type remains unknown when set to true, but uses
the schema type otherwise. The union is required since otherwise the
index type might conflict with other declared properties
begin incremental adoption of prettier in the codebase, I've been
putting it off to try and keep diff's more readable, but think it's
time
replace inline
{[key: string]: never }type with a staticEmptyObjecttype tobetter communicate the intention
mostly solves #44 although currently the schema builder completely ignores
additionalPropertiesmeaning that they won't work correctly for thekoatemplate yet