fix: switch to qs and add tests for query string #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- switch to qs package as this advertises support for arrays/objects more so than the built-in node:querystring library - add tests for query string serialization I'm not 100% sure that this is actually what we want, or at least what we always want. It could well be that we need to provide configuration to control how arrays/objects are handled for serialization, as I suspect different API's will have different opinions on this. Currently it's also ignoring the serialization hint parameters like style/explode - just adding a todo for now.
mnahkies
added a commit
that referenced
this pull request
Apr 23, 2023
- obtained from https://github.com/stripe/openapi - licensed as MIT (https://github.com/stripe/openapi/blob/master/LICENSE) although this is currently missing from the specification itself (see stripe/openapi#120) surfaced numerous issues that are now fixed: - #50 - #55 - #56 - #57 - #58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
switch to qs package as this advertises support for arrays/objects more so than the built-in node:querystring library
add tests for query string serialization
I'm not 100% sure that this is actually what we want, or at least what we always want. It could well be that we need to provide configuration to control how arrays/objects are handled for serialization, as I suspect different API's will have different opinions on this.
Currently it's also ignoring the serialization hint parameters like style/explode - just adding a todo for now.