Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP [ENH,MAINT] More build options #950

Merged
merged 18 commits into from
Apr 26, 2023
Merged

Conversation

gabrielbmotta
Copy link
Collaborator

@gabrielbmotta gabrielbmotta commented Apr 18, 2023

Add the following options to the build project script:

  • [qt=] - lets user specify a path to the desired qt installation to use to build the project.
  • [all] - build all project components (libraries, applications, tests, examples)

Change cmake build flags to positive statements rather than double negatives (instead of setting DO_NOT_BUILD_X to OFF we now set BUILD_X to ON)

  • Add some group build options for only building realtime or offline apps. (saves a bit of time if you need to rebuild from scratch)
  • Turn off examples and tests by default - not too sure about this behavior, but it would save some time when developing. Maybe as an option instead? Thoughts?

@gabrielbmotta gabrielbmotta changed the title [ENH,MAINT] More build options WIP [ENH,MAINT] More build options Apr 18, 2023
echo "[clean] - Delete build and out folders for your configuration and exit."
echo "[clean-all] - Delete all build and out folders."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... and exit?

@juangpc
Copy link
Collaborator

juangpc commented Apr 19, 2023

Thoughts/ideas on Specifics:
"clean-all" vs "rm -fr build out" .
Qt version opt vs "-- -DQtDir=... "
"chill" vs "parallel=false" (true by default)...

We're reaching a point where the number of options is becoming * almost * too broad. But I guess you probably agree on this, so you're adding all these options because... (my guess is that) it allows to interface always with the build script in the ci? Once we reach a point where all the ci workflows and our typical workflow already are able to use this build script, I think it is a good point to stop and do not add more options. After all there is this extra args thing after "--" which allows to directly interface with any option cmake might use.

juangpc
juangpc previously approved these changes Apr 19, 2023
juangpc
juangpc previously approved these changes Apr 20, 2023
@gabrielbmotta gabrielbmotta merged commit 18d550f into mne-tools:main Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants