-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP [ENH,MAINT] More build options #950
Conversation
tools/build_project.bat
Outdated
echo "[clean] - Delete build and out folders for your configuration and exit." | ||
echo "[clean-all] - Delete all build and out folders." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... and exit?
Thoughts/ideas on Specifics: We're reaching a point where the number of options is becoming * almost * too broad. But I guess you probably agree on this, so you're adding all these options because... (my guess is that) it allows to interface always with the build script in the ci? Once we reach a point where all the ci workflows and our typical workflow already are able to use this build script, I think it is a good point to stop and do not add more options. After all there is this extra args thing after "--" which allows to directly interface with any option cmake might use. |
Add the following options to the build project script:
Change cmake build flags to positive statements rather than double negatives (instead of setting DO_NOT_BUILD_X to OFF we now set BUILD_X to ON)