Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EEGLAB file export data type issue #11031

Closed
arnodelorme opened this issue Aug 12, 2022 · 2 comments
Closed

EEGLAB file export data type issue #11031

arnodelorme opened this issue Aug 12, 2022 · 2 comments
Labels

Comments

@arnodelorme
Copy link

Reading a file exported by MNE on MATLAB

EEG.trials

ans =

  int64

   105

The type is int64 instead of double. This can cause all kinds of problems (I was trying to use the number of trials to calculate a ratio, and it was always returning the wrong value for example). This might be the case as well for other fields.

@cbrnr
Copy link
Contributor

cbrnr commented Aug 12, 2022

It could be argued that this is an issue with MATLAB. The number of trials is an integer number. Do integers need to be converted to floats when performing division etc.?

@larsoner
Copy link
Member

As a heavy (mostly ex-)MATLAB user, I would say it's quite unexpected that anything numeric is not double in MATLAB. In this sense I am with @arnodelorme (and more than willing to defer to his expertise here!) that we should cast these to double. I'll reopen this in eeglabio, though, which is where this change would need to happen (cc @jackz314 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants