-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read raw eyelink fix #11823
Read raw eyelink fix #11823
Commits on Jul 21, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 99a0abf - Browse repository at this point
Copy the full SHA 99a0abfView commit details -
Merge branch 'main' of https://github.com/mne-tools/mne-python into r…
…ead_raw_eyelink_fix
Configuration menu - View commit details
-
Copy full SHA for 16d2d6f - Browse repository at this point
Copy the full SHA 16d2d6fView commit details
Commits on Jul 22, 2023
-
PERF: more performance improvements
pd.replace is very slow. Using numpy is 10x faster on a large file. for example on a file with 4 million lines, pd.replace takes 30 seconds and using numpy where takes 2.5 seconds. Also nested the system message check in parse_recordings blocks under the block of code where we know those messages appear. this way we dont check for system messages on literally every line of the file!
Configuration menu - View commit details
-
Copy full SHA for 0514b6d - Browse repository at this point
Copy the full SHA 0514b6dView commit details
Commits on Jul 25, 2023
-
new test creates a new temp file and adds additional channels so that more of read_raw_eyelink will be touched in testing
Configuration menu - View commit details
-
Copy full SHA for bfa4416 - Browse repository at this point
Copy the full SHA bfa4416View commit details -
Merge remote-tracking branch 'upstream/main' into read_raw_eyelink_fix
fixed conflict in test_eyelink from 11826
Configuration menu - View commit details
-
Copy full SHA for 68f8401 - Browse repository at this point
Copy the full SHA 68f8401View commit details -
Apply suggestions from code review [ci skip]
Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for b704b79 - Browse repository at this point
Copy the full SHA b704b79View commit details -
now that we use the tmp_path fixture, no unlinking needed
Configuration menu - View commit details
-
Copy full SHA for 7d45f5d - Browse repository at this point
Copy the full SHA 7d45f5dView commit details
Commits on Jul 26, 2023
-
FIX: Use mne.utils.warn as suggested by Dan
Required update of tests to catch warnings
Configuration menu - View commit details
-
Copy full SHA for 9f76eae - Browse repository at this point
Copy the full SHA 9f76eaeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 647a0b4 - Browse repository at this point
Copy the full SHA 647a0b4View commit details