Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read raw eyelink fix #11823

Merged
merged 9 commits into from
Jul 26, 2023
Merged

Commits on Jul 21, 2023

  1. Configuration menu
    Copy the full SHA
    99a0abf View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    16d2d6f View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2023

  1. PERF: more performance improvements

    pd.replace is very slow. Using numpy is 10x faster on a large file.
    for example on a file with 4 million lines, pd.replace takes 30 seconds
    and using numpy where takes 2.5 seconds.
    
    Also nested the system message check in parse_recordings blocks under
    the block of code where we know those messages appear. this way we dont
    check for system messages on literally every line of the file!
    scott-huberty committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    0514b6d View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2023

  1. FIX: Add tests

    new test creates a new temp file and adds additional channels so that more of
    read_raw_eyelink will be touched in testing
    scott-huberty committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    bfa4416 View commit details
    Browse the repository at this point in the history
  2. Merge remote-tracking branch 'upstream/main' into read_raw_eyelink_fix

    fixed conflict in test_eyelink from 11826
    scott-huberty committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    68f8401 View commit details
    Browse the repository at this point in the history
  3. Apply suggestions from code review [ci skip]

    Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
    scott-huberty and larsoner authored Jul 25, 2023
    Configuration menu
    Copy the full SHA
    b704b79 View commit details
    Browse the repository at this point in the history
  4. FIX: remove unlink

    now that we use the tmp_path fixture, no unlinking needed
    scott-huberty committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    7d45f5d View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2023

  1. FIX: Use mne.utils.warn as suggested by Dan

    Required update of tests to catch warnings
    scott-huberty committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    9f76eae View commit details
    Browse the repository at this point in the history
  2. DOC: update changelog

    scott-huberty committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    647a0b4 View commit details
    Browse the repository at this point in the history