-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: Speed up doc build #12040
MAINT: Speed up doc build #12040
Conversation
Based on main and PR timings, looks like we got:
Comparing the renderings they look okay to me as well. Ready for review/merge from my end! |
report.parse_folder( | ||
data_path, pattern=pattern, render_bem=False, n_time_points_evokeds=5 | ||
) | ||
report.save("report_parse_folder_cov.html", overwrite=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why removing this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is already a section on noise cov viz above. The point is already made elsewhere that parse_folder is cool and usable. So what this adds is explanation of what I'd consider a rare enough use case to omit.
I feel like explaining so many options and configurations can actually be a detriment sometimes. This tutorial webpage is quite long so I think condensing is useful. I was tempted to further roll add_raw/events/epochs/evoked/cov into a "sensor" block/report and add_bem/fwd/inv/stc into a "source" report rather than generating 9 separate reports for these for example. But that seemed a bit drastic and wouldn't speed things up anyway...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
Closes #12012
I changed the examples from that issue that I could. I spent a decent amount of time on the others but couldn't improve their times and/or memory usages.