Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin h5io to >= 0.2.4 #12729

Merged
merged 1 commit into from
Jul 18, 2024
Merged

pin h5io to >= 0.2.4 #12729

merged 1 commit into from
Jul 18, 2024

Conversation

drammock
Copy link
Member

needed for datetime.date support; otherwise writing to hdf5 will fail sometimes (e.g., the nirx tests; noticed when looking into mne-tools/mne-nirs#543, not sure why that didn't surface in #12720)

cc @larsoner

@drammock drammock requested a review from larsoner as a code owner July 17, 2024 20:16
@larsoner larsoner merged commit f0e50d7 into mne-tools:main Jul 18, 2024
30 checks passed
@larsoner
Copy link
Member

Thanks @drammock !

This probably did not surface because by default it will always install the most up-to-date version. Our old CI installs oldest versions of only some core packages like SciPy, NumPy, Pandas, etc. It might not install (or restrict the version of) other stuff like h5io.

@drammock drammock deleted the pin-h5io branch July 18, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants