Pre-allocate buffer for pylsl's .pull_chunk for faster reads
#47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlesbmi
force-pushed
the
preallocate-lsl-buffer
branch
from
62828a1
to
0390ec3
Compare
|
looks fair ... you might save some additional time by avoiding the Any test to update/add? |
teonbrooks
reviewed
Apr 11, 2023
larsoner
approved these changes
Apr 11, 2023
There was a problem hiding this comment.
@teonbrooks looks good to me, feel free to merge if you're happy!
charlesbmi
force-pushed
the
preallocate-lsl-buffer
branch
from
b60608c
to
8afea38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful for high sampling rates (and just better latency), as recommended by: https://labstreaminglayer.readthedocs.io/info/faqs.html#high-sampling-rates