-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make .get_data_as_epoch
timeout a configurable parameter
#49
Conversation
Should we change MNE-Python to allow |
Seems reasonable to me! The specific error raised here is because the array is empty with shape Separately, looks like the jobs are failing due to https://community.codecov.com/t/codecov-yanked-from-pypi-all-versions/4259/9 |
The update I pushed should fix the codecov problem Feel free to make a PR to allow 0 length EpochsArray. Maybe not for no time points, but it seems reasonable for zero epochs |
Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than one more numpydoc formatting thing, LGTM +1 for merge!
Marking for merge when green @charlesincharge , thanks in advance! |
As someone creating a real-time application, I sometimes want to limit the amount of time the application is waiting on data. This change makes
wait_time
(now calledtimeout
) a configurable parameter.In the situation that data is not ready before the timeout,
.get_data_as_epoch
now returnsNone
becauseEpochsArray(data,...)
errors out whendata
is an empty array.Note: it was possible for
data
to be empty even before the change, although a shortertimeout
now makes this more likely.