Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing double type without decimal point #68

Conversation

nallwhy
Copy link
Contributor

@nallwhy nallwhy commented Nov 8, 2021

InfluxDB can send double type values without a decimal point.
To handle this, use Float.parse/1 instead of String.to_float/1.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.0%) to 74.221% when pulling d135a1d on nallwhy:fix_parsing_double_type_without_decimal_point into 6fff364 on mneudert:master.

@coveralls
Copy link

coveralls commented Nov 8, 2021

Coverage Status

Coverage remained the same at 73.247% when pulling cd4d615 on nallwhy:fix_parsing_double_type_without_decimal_point into 6fff364 on mneudert:master.

@Ma233
Copy link
Contributor

Ma233 commented Nov 9, 2021

@nallwhy Hi, would you mind to fix the format? And add some tests like this https://github.com/mneudert/instream/pull/70/files#diff-f89c196f7418cccba10c7749d9fd1311a5ed164bab5338ec8a1a043efcfaad42

@nallwhy nallwhy force-pushed the fix_parsing_double_type_without_decimal_point branch from d135a1d to cd4d615 Compare November 9, 2021 07:21
@nallwhy
Copy link
Contributor Author

nallwhy commented Nov 9, 2021

@nallwhy Hi, would you mind to fix the format? And add some tests like this https://github.com/mneudert/instream/pull/70/files#diff-f89c196f7418cccba10c7749d9fd1311a5ed164bab5338ec8a1a043efcfaad42

Thanks a lot!

@mneudert mneudert merged commit 192c05f into mneudert:master Nov 9, 2021
@mneudert
Copy link
Owner

mneudert commented Nov 9, 2021

❤️ 💚 💙 💛 💜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants