-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Product milestone 1 #21
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I generate a resource there is no property name by default.
@brunobuddy On the create-edit page, when we submit a form with a Date yield, an error says a date is expected when there is a date |
if a resource has no one property, when adding a property to this existing resource generate an error. Command I used to generate a propoerty to the The following error is generated: |
not nullable column date cannot be initialized. We chose to set default to current date
2 things left before publishing:
|
Description
This PR closes the V1 version of the product:
What it does NOT include
Pretty CLI commands
I choose to not include the final CLI syntax to reduce the size of the sprint and the validation (we already have 3 "npm link" to do simultaneously). In addition to that I made some choices (not developed yet) that you will find in the documentation. Maybe we need to discuss those before working on them.
However all the npm scripts below correspond to an explicit "pretty" CLI command that will be added on the next sprint.
Image yield seeder
The features implemented previously in this yield (see screenshot below) have a price: It's hard to deliver a "simple" dummy image seeded. We may want to simplify this yield to make it simpler to use. You can create a resource or a property of the "image" type but you will need to remove the generated image yield in the list component.
How can it be tested?
You should now see that the form is pre-filled when you login:
OK, now you are ready for some testing !!
From the root of your project, type the following commands:
cs generate resource [name]
You can run this command by doing
Don't forget to seed ! This will not be the case in the final CLI
cs generate resource [name] --props=[prop1,prop2]
Same again with the the "props" argument as explained in the doc
Don't forget to seed ! This will not be the case in the final CLI
cs generate property [name] --resource=[resourceName]
Adding a prop to an existing resource is easy
Don't forget to seed ! This will not be the case in the final CLI
All of those commands should work and have a nice experience for the user
Check list before submitting