Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate with package manager #141

Closed
buihuuloc opened this issue Dec 22, 2018 · 16 comments
Closed

Integrate with package manager #141

buihuuloc opened this issue Dec 22, 2018 · 16 comments

Comments

@buihuuloc
Copy link

Hi @mob-sakai,

Can you give me an idea to let the package works with Package Manager?

Thanks!

@mob-sakai mob-sakai self-assigned this Dec 22, 2018
@mob-sakai
Copy link
Owner

Hi @buihuuloc
It's very important :)

I have an idea, but you will need to change the directory structure ...

@mob-sakai
Copy link
Owner

@buihuuloc
Copy link
Author

I'm trying to test with npm package.
However, it isn't working for me

Added two lines in manifest.json file

{  
 "registry": "https://registry.npmjs.org",

  "dependencies": {
       "uieffectupm":"4.0.1"
   }
}

@buihuuloc
Copy link
Author

I just published a new version 4.0.2.
And It's working now. 🤗

@mob-sakai
Copy link
Owner

Awesome!
It works fine for me, on 2018.3.0f2!

@mob-sakai
Copy link
Owner

Hmm, this way seems to have a problem.
Uninstalled packages are not displayed in PackageManager...

Error message

Cannot perform upm operation: Package [com.unity.package-manager.metadata] cannot be found [NotFound]
Error searching packages online.

@buihuuloc
Copy link
Author

I found the problem.
We need to use the scope registries, instead of using the global registry.

{
  "scopedRegistries": [
    {
      "name": "UI Effect",
      "url": "https://registry.npmjs.org",
      "scopes": [
        "uieffectupm"
      ]
    }
  ],
  "dependencies": {
    "uieffectupm":"4.0.2"
 }
}

@buihuuloc
Copy link
Author

@mob-sakai
Copy link
Owner

Excellent, @buihuuloc !

@mob-sakai
Copy link
Owner

mob-sakai commented Dec 25, 2018

Assets in the Package directory can not be modified.
Like TextMeshPro, we should include the resource as unitypackage in the package.

@buihuuloc
Copy link
Author

If there a way to handle post-install package event with Package Manager, I think we can do it.
Otherwise, we can have an editor menu to import the external resources folder.

@mob-sakai
Copy link
Owner

mob-sakai commented Dec 27, 2018

By using InitializeOnLoadMethod attribute, it is possible to import packages after compilation.

@mob-sakai
Copy link
Owner

If there a way to handle post-install package event with Package Manager, I think we can do it.

I think it is necessary to implement IPackageManagerExtension.

@JesseTG
Copy link

JesseTG commented Jul 8, 2019

What if you try this new thing?

@mob-sakai
Copy link
Owner

Hi @JesseTG
Maybe, it will work.

github-actions bot pushed a commit that referenced this issue Apr 10, 2020
# [4.0.0-preview.1](v3.2.0...v4.0.0-preview.1) (2020-04-10)

### Bug Fixes

* adjusting the brightness of the shiny shader ([29b4dad](29b4dad))
* the effect is kept even if the component is disabled (UIFlip, UIGradient) ([6124214](6124214))

### Features

* add asmdef files ([24710fc](24710fc))
* new effect that synchronize with another effect ([7a2a97c](7a2a97c)), closes [#159](#159) [#158](#158) [#143](#143)
* transfer TextMeshPro support to another package ([be90210](be90210))
* transfer UIEffectCapturedImage support to another package ([c2a2320](c2a2320))
* update docs to support Unity Package Manager ([bdc891a](bdc891a)), closes [#141](#141)
* update the effect architecture ([4c08c8c](4c08c8c)), closes [#202](#202) [#198](#198) [#195](#195) [#189](#189) [#173](#173) [#104](#104)
* update the structure of shaders ([db06e68](db06e68))
* updated the Unity version used for development to 2018.3 ([c5f22c1](c5f22c1)), closes [#169](#169)

### BREAKING CHANGES

* Scenes, prefabs and scripts using UIEffect v3.x may not work properly.
* The recommended Unity version is 2018.1 or later; it will work with Unity 2017.1, but it is not guaranteed to be supported.
* UIEffectCapturedImage will be supported by another package.
* TextMeshPro support has been removed from this package. It will be supported by another package.
github-actions bot pushed a commit that referenced this issue Apr 10, 2020
# [4.0.0-preview.1](v3.2.0...v4.0.0-preview.1) (2020-04-10)

### Bug Fixes

* adjusting the brightness of the shiny shader ([29b4dad](29b4dad))
* the effect is kept even if the component is disabled (UIFlip, UIGradient) ([6124214](6124214))

### Features

* add asmdef files ([24710fc](24710fc))
* new effect that synchronize with another effect ([7a2a97c](7a2a97c)), closes [#159](#159) [#158](#158) [#143](#143)
* transfer TextMeshPro support to another package ([be90210](be90210))
* transfer UIEffectCapturedImage support to another package ([c2a2320](c2a2320))
* update docs to support Unity Package Manager ([bdc891a](bdc891a)), closes [#141](#141)
* update the effect architecture ([4c08c8c](4c08c8c)), closes [#202](#202) [#198](#198) [#195](#195) [#189](#189) [#173](#173) [#104](#104)
* update the structure of shaders ([db06e68](db06e68))
* updated the Unity version used for development to 2018.3 ([c5f22c1](c5f22c1)), closes [#169](#169)

### BREAKING CHANGES

* Scenes, prefabs and scripts using UIEffect v3.x may not work properly.
* The recommended Unity version is 2018.1 or later; it will work with Unity 2017.1, but it is not guaranteed to be supported.
* UIEffectCapturedImage will be supported by another package.
* TextMeshPro support has been removed from this package. It will be supported by another package.
@github-actions
Copy link

🎉 This issue has been resolved in version 4.0.0-preview.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

kekouyang pushed a commit to kekouyang/UIEffect that referenced this issue May 5, 2023
# [4.0.0-preview.1](mob-sakai/UIEffect@v3.2.0...v4.0.0-preview.1) (2020-04-10)

### Bug Fixes

* adjusting the brightness of the shiny shader ([29b4dad](mob-sakai@29b4dad))
* the effect is kept even if the component is disabled (UIFlip, UIGradient) ([6124214](mob-sakai@6124214))

### Features

* add asmdef files ([24710fc](mob-sakai@24710fc))
* new effect that synchronize with another effect ([7a2a97c](mob-sakai@7a2a97c)), closes [mob-sakai#159](mob-sakai#159) [mob-sakai#158](mob-sakai#158) [mob-sakai#143](mob-sakai#143)
* transfer TextMeshPro support to another package ([be90210](mob-sakai@be90210))
* transfer UIEffectCapturedImage support to another package ([c2a2320](mob-sakai@c2a2320))
* update docs to support Unity Package Manager ([bdc891a](mob-sakai@bdc891a)), closes [mob-sakai#141](mob-sakai#141)
* update the effect architecture ([4c08c8c](mob-sakai@4c08c8c)), closes [mob-sakai#202](mob-sakai#202) [mob-sakai#198](mob-sakai#198) [mob-sakai#195](mob-sakai#195) [mob-sakai#189](mob-sakai#189) [mob-sakai#173](mob-sakai#173) [mob-sakai#104](mob-sakai#104)
* update the structure of shaders ([db06e68](mob-sakai@db06e68))
* updated the Unity version used for development to 2018.3 ([c5f22c1](mob-sakai@c5f22c1)), closes [mob-sakai#169](mob-sakai#169)

### BREAKING CHANGES

* Scenes, prefabs and scripts using UIEffect v3.x may not work properly.
* The recommended Unity version is 2018.1 or later; it will work with Unity 2017.1, but it is not guaranteed to be supported.
* UIEffectCapturedImage will be supported by another package.
* TextMeshPro support has been removed from this package. It will be supported by another package.
AwfulDarkness0110 added a commit to AwfulDarkness0110/UIEffect that referenced this issue Jun 28, 2023
# [4.0.0-preview.1](mob-sakai/UIEffect@v3.2.0...v4.0.0-preview.1) (2020-04-10)

### Bug Fixes

* adjusting the brightness of the shiny shader ([29b4dad](mob-sakai/UIEffect@29b4dad))
* the effect is kept even if the component is disabled (UIFlip, UIGradient) ([6124214](mob-sakai/UIEffect@6124214))

### Features

* add asmdef files ([24710fc](mob-sakai/UIEffect@24710fc))
* new effect that synchronize with another effect ([7a2a97c](mob-sakai/UIEffect@7a2a97c)), closes [#159](mob-sakai/UIEffect#159) [#158](mob-sakai/UIEffect#158) [#143](mob-sakai/UIEffect#143)
* transfer TextMeshPro support to another package ([be90210](mob-sakai/UIEffect@be90210))
* transfer UIEffectCapturedImage support to another package ([c2a2320](mob-sakai/UIEffect@c2a2320))
* update docs to support Unity Package Manager ([bdc891a](mob-sakai/UIEffect@bdc891a)), closes [#141](mob-sakai/UIEffect#141)
* update the effect architecture ([4c08c8c](mob-sakai/UIEffect@4c08c8c)), closes [#202](mob-sakai/UIEffect#202) [#198](mob-sakai/UIEffect#198) [#195](mob-sakai/UIEffect#195) [#189](mob-sakai/UIEffect#189) [#173](mob-sakai/UIEffect#173) [#104](mob-sakai/UIEffect#104)
* update the structure of shaders ([db06e68](mob-sakai/UIEffect@db06e68))
* updated the Unity version used for development to 2018.3 ([c5f22c1](mob-sakai/UIEffect@c5f22c1)), closes [#169](mob-sakai/UIEffect#169)

### BREAKING CHANGES

* Scenes, prefabs and scripts using UIEffect v3.x may not work properly.
* The recommended Unity version is 2018.1 or later; it will work with Unity 2017.1, but it is not guaranteed to be supported.
* UIEffectCapturedImage will be supported by another package.
* TextMeshPro support has been removed from this package. It will be supported by another package.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants