Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can dissolve apply to entire hierarchy? #158

Closed
efarraro opened this issue Mar 16, 2019 · 8 comments
Closed

Can dissolve apply to entire hierarchy? #158

efarraro opened this issue Mar 16, 2019 · 8 comments

Comments

@efarraro
Copy link

efarraro commented Mar 16, 2019

Can UIDissolve be applied to an entire hierarchy? I see that if I apply UIDissolve directly to a UGUI image, it works great.

But assume I have a parent GameObject and that GameObject has some images below it. Something like this:

GameObject
        Image1
        Image2

If I apply UIDissolve to the GameObject, it doesn't appear to work. Instead, I need to apply UIDissolve to each Image individually. Is there any way to apply UIDissolve at the parent object and have it dissolve all the children?

@mob-sakai mob-sakai self-assigned this Mar 17, 2019
@mob-sakai
Copy link
Owner

Hi @efarraro
Yes, "hierarchical effect" is one of the features to be implemented. #143
I will implement it in the near future. :)

@efarraro
Copy link
Author

Thanks for the quick response @mob-sakai and all your hard work on this project!

mob-sakai added a commit that referenced this issue Apr 10, 2020
With UISyncEffect, you can apply the same effect as any other effect component.

Close #159, #158, #143
mob-sakai added a commit that referenced this issue Apr 10, 2020
With UISyncEffect, you can apply the same effect as any other effect component.

Close #159, #158, #143
github-actions bot pushed a commit that referenced this issue Apr 10, 2020
# [4.0.0-preview.1](v3.2.0...v4.0.0-preview.1) (2020-04-10)

### Bug Fixes

* adjusting the brightness of the shiny shader ([29b4dad](29b4dad))
* the effect is kept even if the component is disabled (UIFlip, UIGradient) ([6124214](6124214))

### Features

* add asmdef files ([24710fc](24710fc))
* new effect that synchronize with another effect ([7a2a97c](7a2a97c)), closes [#159](#159) [#158](#158) [#143](#143)
* transfer TextMeshPro support to another package ([be90210](be90210))
* transfer UIEffectCapturedImage support to another package ([c2a2320](c2a2320))
* update docs to support Unity Package Manager ([bdc891a](bdc891a)), closes [#141](#141)
* update the effect architecture ([4c08c8c](4c08c8c)), closes [#202](#202) [#198](#198) [#195](#195) [#189](#189) [#173](#173) [#104](#104)
* update the structure of shaders ([db06e68](db06e68))
* updated the Unity version used for development to 2018.3 ([c5f22c1](c5f22c1)), closes [#169](#169)

### BREAKING CHANGES

* Scenes, prefabs and scripts using UIEffect v3.x may not work properly.
* The recommended Unity version is 2018.1 or later; it will work with Unity 2017.1, but it is not guaranteed to be supported.
* UIEffectCapturedImage will be supported by another package.
* TextMeshPro support has been removed from this package. It will be supported by another package.
github-actions bot pushed a commit that referenced this issue Apr 10, 2020
# [4.0.0-preview.1](v3.2.0...v4.0.0-preview.1) (2020-04-10)

### Bug Fixes

* adjusting the brightness of the shiny shader ([29b4dad](29b4dad))
* the effect is kept even if the component is disabled (UIFlip, UIGradient) ([6124214](6124214))

### Features

* add asmdef files ([24710fc](24710fc))
* new effect that synchronize with another effect ([7a2a97c](7a2a97c)), closes [#159](#159) [#158](#158) [#143](#143)
* transfer TextMeshPro support to another package ([be90210](be90210))
* transfer UIEffectCapturedImage support to another package ([c2a2320](c2a2320))
* update docs to support Unity Package Manager ([bdc891a](bdc891a)), closes [#141](#141)
* update the effect architecture ([4c08c8c](4c08c8c)), closes [#202](#202) [#198](#198) [#195](#195) [#189](#189) [#173](#173) [#104](#104)
* update the structure of shaders ([db06e68](db06e68))
* updated the Unity version used for development to 2018.3 ([c5f22c1](c5f22c1)), closes [#169](#169)

### BREAKING CHANGES

* Scenes, prefabs and scripts using UIEffect v3.x may not work properly.
* The recommended Unity version is 2018.1 or later; it will work with Unity 2017.1, but it is not guaranteed to be supported.
* UIEffectCapturedImage will be supported by another package.
* TextMeshPro support has been removed from this package. It will be supported by another package.
mob-sakai added a commit that referenced this issue Apr 10, 2020
Close leaked issues.
Close #198, Close #195, Close #189, Close #173, Close #104, Close #158, Close #143
github-actions bot pushed a commit that referenced this issue Apr 10, 2020
# [4.0.0-preview.2](v4.0.0-preview.1...v4.0.0-preview.2) (2020-04-10)

### Bug Fixes

* compilation fails on build ([f34ae2c](f34ae2c))
* fix project settings ([8685165](8685165)), closes [#198](#198) [#195](#195) [#189](#189) [#173](#173) [#104](#104) [#158](#158) [#143](#143)
github-actions bot pushed a commit that referenced this issue Apr 10, 2020
# [4.0.0-preview.2](v4.0.0-preview.1...v4.0.0-preview.2) (2020-04-10)

### Bug Fixes

* compilation fails on build ([f34ae2c](f34ae2c))
* fix project settings ([8685165](8685165)), closes [#198](#198) [#195](#195) [#189](#189) [#173](#173) [#104](#104) [#158](#158) [#143](#143)
@github-actions
Copy link

🎉 This issue has been resolved in version 4.0.0-preview.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@efarraro
Copy link
Author

HI @mob-sakai ! I tried this one after updating my manifest.json to use this version:
"com.coffee.ui-effect": "https://github.com/mob-sakai/UIEffect.git#4.0.0-preview.6"

To test it, I created a 2D Unity UI canvas, then added an Image (a white square) and put a smaller child (a red square). I applied the UIDissolve behavior to the parent. The dissolve affected the parent, but did not affect the child.

Is there anything else I might be missing to have the dissolve effect dissolve the whole hierarchy? I saw your recent reboot / 4.0 version. I really appreciate your work on this library - it's one of my favorites!

@mob-sakai
Copy link
Owner

@efarraro
Sorry! I forgot to explain the hierarchical effects feature.

Attach a UISyncEffect component to the child object instead of a UIDissolve component.

@mob-sakai
Copy link
Owner

However, this feature is experimental.
In the future, UISyncEffect may be deprecated and integrated into UIDissolve (or any other effect).

@efarraro
Copy link
Author

Understood! I think that's OK for my purposes. Thank you so much for the response!

@efarraro
Copy link
Author

One more suggestion that would be nice (if it's possible!) I tried the sync effect and it works as expected. It would be useful to be able to apply to a root object that's not something like an image (for instance, just a plain game object). Something like:

GameObject -> Image -> Image

Right now, you get a popup error in the editor if you try to apply the UIDissolve to something like a plain GameObject. I got around it by just adding an Image to my root game object and disabling (unchecking) the Image script so that it didn't show up. Not sure if this is just a limitation of how the effect is applied (maybe it requires an image?), but I figured I'd mention here, just in case. Most of my hierarchies use a 'plain' GameObject as the root, and it'd be useful to be able to apply the effect to that root.

kekouyang pushed a commit to kekouyang/UIEffect that referenced this issue May 5, 2023
# [4.0.0-preview.1](mob-sakai/UIEffect@v3.2.0...v4.0.0-preview.1) (2020-04-10)

### Bug Fixes

* adjusting the brightness of the shiny shader ([29b4dad](mob-sakai@29b4dad))
* the effect is kept even if the component is disabled (UIFlip, UIGradient) ([6124214](mob-sakai@6124214))

### Features

* add asmdef files ([24710fc](mob-sakai@24710fc))
* new effect that synchronize with another effect ([7a2a97c](mob-sakai@7a2a97c)), closes [mob-sakai#159](mob-sakai#159) [mob-sakai#158](mob-sakai#158) [mob-sakai#143](mob-sakai#143)
* transfer TextMeshPro support to another package ([be90210](mob-sakai@be90210))
* transfer UIEffectCapturedImage support to another package ([c2a2320](mob-sakai@c2a2320))
* update docs to support Unity Package Manager ([bdc891a](mob-sakai@bdc891a)), closes [mob-sakai#141](mob-sakai#141)
* update the effect architecture ([4c08c8c](mob-sakai@4c08c8c)), closes [mob-sakai#202](mob-sakai#202) [mob-sakai#198](mob-sakai#198) [mob-sakai#195](mob-sakai#195) [mob-sakai#189](mob-sakai#189) [mob-sakai#173](mob-sakai#173) [mob-sakai#104](mob-sakai#104)
* update the structure of shaders ([db06e68](mob-sakai@db06e68))
* updated the Unity version used for development to 2018.3 ([c5f22c1](mob-sakai@c5f22c1)), closes [mob-sakai#169](mob-sakai#169)

### BREAKING CHANGES

* Scenes, prefabs and scripts using UIEffect v3.x may not work properly.
* The recommended Unity version is 2018.1 or later; it will work with Unity 2017.1, but it is not guaranteed to be supported.
* UIEffectCapturedImage will be supported by another package.
* TextMeshPro support has been removed from this package. It will be supported by another package.
kekouyang pushed a commit to kekouyang/UIEffect that referenced this issue May 5, 2023
AwfulDarkness0110 added a commit to AwfulDarkness0110/UIEffect that referenced this issue Jun 28, 2023
# [4.0.0-preview.1](mob-sakai/UIEffect@v3.2.0...v4.0.0-preview.1) (2020-04-10)

### Bug Fixes

* adjusting the brightness of the shiny shader ([29b4dad](mob-sakai/UIEffect@29b4dad))
* the effect is kept even if the component is disabled (UIFlip, UIGradient) ([6124214](mob-sakai/UIEffect@6124214))

### Features

* add asmdef files ([24710fc](mob-sakai/UIEffect@24710fc))
* new effect that synchronize with another effect ([7a2a97c](mob-sakai/UIEffect@7a2a97c)), closes [#159](mob-sakai/UIEffect#159) [#158](mob-sakai/UIEffect#158) [#143](mob-sakai/UIEffect#143)
* transfer TextMeshPro support to another package ([be90210](mob-sakai/UIEffect@be90210))
* transfer UIEffectCapturedImage support to another package ([c2a2320](mob-sakai/UIEffect@c2a2320))
* update docs to support Unity Package Manager ([bdc891a](mob-sakai/UIEffect@bdc891a)), closes [#141](mob-sakai/UIEffect#141)
* update the effect architecture ([4c08c8c](mob-sakai/UIEffect@4c08c8c)), closes [#202](mob-sakai/UIEffect#202) [#198](mob-sakai/UIEffect#198) [#195](mob-sakai/UIEffect#195) [#189](mob-sakai/UIEffect#189) [#173](mob-sakai/UIEffect#173) [#104](mob-sakai/UIEffect#104)
* update the structure of shaders ([db06e68](mob-sakai/UIEffect@db06e68))
* updated the Unity version used for development to 2018.3 ([c5f22c1](mob-sakai/UIEffect@c5f22c1)), closes [#169](mob-sakai/UIEffect#169)

### BREAKING CHANGES

* Scenes, prefabs and scripts using UIEffect v3.x may not work properly.
* The recommended Unity version is 2018.1 or later; it will work with Unity 2017.1, but it is not guaranteed to be supported.
* UIEffectCapturedImage will be supported by another package.
* TextMeshPro support has been removed from this package. It will be supported by another package.
AwfulDarkness0110 added a commit to AwfulDarkness0110/UIEffect that referenced this issue Jun 28, 2023
# [4.0.0-preview.2](mob-sakai/UIEffect@v4.0.0-preview.1...v4.0.0-preview.2) (2020-04-10)

### Bug Fixes

* compilation fails on build ([f34ae2c](mob-sakai/UIEffect@f34ae2c))
* fix project settings ([8685165](mob-sakai/UIEffect@8685165)), closes [#198](mob-sakai/UIEffect#198) [#195](mob-sakai/UIEffect#195) [#189](mob-sakai/UIEffect#189) [#173](mob-sakai/UIEffect#173) [#104](mob-sakai/UIEffect#104) [#158](mob-sakai/UIEffect#158) [#143](mob-sakai/UIEffect#143)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants