Release v2.0.1 #77
Release v2.0.1 #77
Conversation
Fix shade reference
stop viewport being set at window.innerHeight
Fix/test coverage
…closing animation
Fix/custom containers
|
Excited that this is still actively developed! Nice work @ericawright. |
|
@ericawright do we want to get the changes to bower into this release? |
|
@jansepar it seems like it, at least that was what was suggested |
|
I suggested to include the bower changes since this release is already a major upgrade to what's currently public. |
|
Maybe this is a bit too "blue-sky" for our current resourcing/workload, but it would be cool to see this release of Pikabu bring it up to current best practices like:
I'm happy to answer any questions about these best practices and how to make them happen. |
|
@marlowpayne I agree these are great things to happen eventually, but the scope of this release should be to "release a working Pikabu 2.0" as the original Pikabu 2.0 release was broken. My recommendation would be to publish this release (unless there are functional blockers), and work on your items in 2.0.2. |
Due to an issue in some browsers, using `@support` breaks the `:not()` CSS pseudo selector. See here: https://bugs.chromium.org/p/chromium/issues/detail?id=257695 In particular, this was an issue in our project here: https://mobify.atlassian.net/browse/CF-105 Also: Removed the Chrome specific fix from before, as I cannot reproduce that particular issue anymore.
This was here before the original introduction of `@support`, so the `width: 100%` should be re-added.
Remove `@support`
change all bower_components to node_modules
Status: Ready for Review
Owner: @ericawright
Reviewers: @johnboxall @fractaltheory @MikeKlemarewski @mikenikles @stewartyu
Version 2.0.1 release
Issues Fixed
#66
#65
#60
#51
#49