Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Protocol family unavailable" on rerun after failure #1671

Merged
merged 1 commit into from
May 21, 2024

Conversation

sjchmiela
Copy link
Contributor

@sjchmiela sjchmiela commented Feb 5, 2024

Proposed Changes

I think xcTestDriverStatusCheck may return a response object with an error response or throw. In isChannelAlive, where we care about whether channel is alive we should treat an exception as an isChannelAlive = false.

Testing

I verified this is valid Kotlin code and looks similar to ensureOpen.

Issues Fixed

I've run into the "Protocol family unavailable" after a CI-run test job fails to connect to XCUITest server. I believe the xcTestDriverStatusCheck should be wrapped with try-catch, as it is in ensureOpen().

@sjchmiela sjchmiela marked this pull request as ready for review February 5, 2024 21:43
@axelniklasson axelniklasson added external-contribution bug Something isn't working platform: ios Testing iOS apps is affected labels May 20, 2024
@amanjeetsingh150
Copy link
Collaborator

Thanks @sjchmiela for the contribution. This should be out next release!

@amanjeetsingh150 amanjeetsingh150 merged commit 1d6f429 into mobile-dev-inc:main May 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working platform: ios Testing iOS apps is affected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants