Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

Arch overhaul 2: Electric Boogaloo #162

Merged
merged 34 commits into from
Jun 20, 2018
Merged

Arch overhaul 2: Electric Boogaloo #162

merged 34 commits into from
Jun 20, 2018

Conversation

hmkrivoj
Copy link
Collaborator

No description provided.

@hmkrivoj hmkrivoj mentioned this pull request Jun 18, 2018
Merged
@coveralls
Copy link

coveralls commented Jun 18, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 780

  • 51 of 442 (11.54%) changed or added relevant lines in 28 files are covered.
  • 4 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+5.1%) to 43.502%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/io/inet/providers/department_provider.dart 0 1 0.0%
lib/io/cache/providers/lecturer_provider.dart 0 1 0.0%
lib/controller/favorites_controller.dart 18 19 94.74%
lib/controller/ics_creator.dart 0 1 0.0%
lib/ui/basic_components/course_list_entry.dart 0 2 0.0%
lib/ui/basic_components/cie_list_entry.dart 0 2 0.0%
lib/ui/scaffolds/course_details.dart 0 2 0.0%
lib/io/cache/providers/user_provider.dart 0 2 0.0%
lib/io/cache/providers/user_settings_provider.dart 0 2 0.0%
lib/io/inet/providers/lecturer_provider.dart 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
lib/ui/scaffolds/login.dart 1 61.61%
lib/model/user/user.dart 1 0.0%
lib/ui/screens/cie_screen.dart 2 20.0%
Totals Coverage Status
Change from base Build 772: 5.1%
Covered Lines: 646
Relevant Lines: 1485
💛 - Coveralls

@hmkrivoj
Extracted interface out of databasehelper
6710ff7
@hmkrivoj
Merge remote-tracking branch 'origin/ArchOverhaul2ElectricBoogalo' in…
9e60a57 
…to ArchOverhaul2ElectricBoogalo
@hmkrivoj
dartfmt party
2dd2af9
@hmkrivoj
add cie scaffold moved to scaffold folder
8888111 
converted cie screen from scaffold to plain container
@hmkrivoj
New directory structure for tests
a2ac6f6
@hmkrivoj
Renamed connect to inet
1556600
@hmkrivoj
Extracted cache and network operations for content(campuses, courses,…
b261c9b 
… departments, lecturers) from session into new ContentController
@hmkrivoj
session controller and user creation controller
c3558a1
@hmkrivoj
Created favorites controller
a677e4a 
database lacks favorites support so i've created an in memory 'cache' for debugging purposes
@hmkrivoj
cie controller finished + little cleanup in cie ui stuff
ac1542c
@hmkrivoj
Created skeleton for settings controller
b4bfa9c
@hmkrivoj hmkrivoj changed the title Arch overhaul 1.5 Arch overhaul 2.0 Jun 19, 2018
@hmkrivoj hmkrivoj changed the title Arch overhaul 2.0 Arch overhaul 2: Electric Boogaloo Jun 19, 2018
Gleydar
Gleydar approved these changes Jun 20, 2018
View reviewed changes
Copy link

@Gleydar Gleydar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost 5000 lines changed, so that seems good for friday :kappa:

@Gleydar Gleydar merged commit 8234d93 into sprint3 Jun 20, 2018
@Gleydar Gleydar deleted the ArchOverhaul2ElectricBoogalo branch June 20, 2018 08:27
@hmkrivoj hmkrivoj mentioned this pull request Jun 20, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Gleydar Gleydar Gleydar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hmkrivoj @coveralls @Gleydar