Add VerificationTreeDisplay

[nick-mobilecoin]

The VerificationTreeDisplay allows one to display the output of a
verification, showing which phases succeeded, which failed and what the
values were for each phase.

Motivation

Future Work

[nick-mobilecoin]

Current dependencies on/for this PR:

• main
  • PR Add TCB struct and parser #83
    • PR Add parsing of the tcbInfo inner field #84
      • PR Add verification of TCB data #85
        • PR Move common types to lib.rs #86
          • PR Convert from CtOption to VerificationOutput #87
            • PR Add VerificationTreeDisplay #48 👈
              • PR Add logic to get Advisories from TcbInfo #89
                • PR Add AdvisoryVerifier #90
                  • PR Bring in MbedTls certificate verification #92
                  • PR Remove unused Certificate and CRL logic #93
                  • PR Add CRL logic to certificate verification #94
                  • PR Add method to get the leaf certificate from cert chain #95
                  • PR Update to the 0.6.1 SGX crate versions #96
              • PR Decode TCB values in PCK leaf certificate #88

This comment was auto-generated by Graphite.

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (nick/change-verifiction-output@a95d42c). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 48f4959 differs from pull request most recent head a83bf08. Consider uploading reports for the commit a83bf08 to get more accurate results

@@                        Coverage Diff                        @@
##             nick/change-verifiction-output      #48   +/-   ##
=================================================================
  Coverage                                  ?   97.10%           
=================================================================
  Files                                     ?        3           
  Lines                                     ?     1003           
  Branches                                  ?        0           
=================================================================
  Hits                                      ?      974           
  Misses                                    ?       29           
  Partials                                  ?        0           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[jcape]

I thought we'd discussed that the primary source of the string at each print should be the display of the verifier...?

[nick-mobilecoin]

I thought we'd discussed that the primary source of the string at each print should be the display of the verifier...?

I think that's the self in this , https://github.com/mobilecoinfoundation/attestation/pull/48/files#diff-fe2f7ab2bdcef7981ced2b0119aa6146527d7beebe5bf3808e8652f6663e1eadR115

write!(f, "{:pad$}{status} {self}", "")?;

There are some places where that isn't done:

• And It felt a little odd to have "the following" if And was displayed by itself, perhaps the message "Both of the following must be true" should be changed to "Both must be true".
• Or similar to above
• Not, AlwaysTrue, AlwaysFalse, I'll work on changing these done in 48f4959
• AttributesVerifier similar to And, the separate line by line comparison doesn't seem to lend itself to the Verifier display well
• MrSignerVerifier similar to the And/AttributesVerifier

[nick-mobilecoin]

my bad @cbeck88, I should have moved this to a draft, I broke it up and refactored in #86 and #87, with a follow on soon

[github-actions]

❌ Unreviewed dependencies found

Crate	Version	Reviews (N/2)	LoC	Left-Pad Index	Geiger	Flags

[nick-mobilecoin]

requested a re-review, @cbeck88, since this got refactored some with the new main line as well as #86 and #87

[cbeck88]

Np

[cbeck88]

This looks good to me