Add logic to get Advisories from TcbInfo
#89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 16, 2023
This was referenced May 16, 2023
This was referenced May 16, 2023
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
❌ Unreviewed dependencies found
|
nick-mobilecoin
commented
May 16, 2023
nick-mobilecoin
force-pushed
the
nick/get-tcb-for-fmspc
branch
from
f157da2
to
a6e418f
Compare
nick-mobilecoin
commented
May 16, 2023
Codecov Report
@@ Coverage Diff @@
## nick/displayable-error-tree #89 +/- ##
===============================================================
+ Coverage 98.26% 98.38% +0.11%
===============================================================
Files 7 7
Lines 1847 1983 +136
===============================================================
+ Hits 1815 1951 +136
Misses 32 32
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Moving to draft. this has |
nick-mobilecoin
force-pushed
the
nick/get-tcb-for-fmspc
branch
from
a6e418f
to
cfd76dc
Compare
nick-mobilecoin
commented
May 16, 2023
nick-mobilecoin
commented
May 16, 2023
nick-mobilecoin
force-pushed
the
nick/get-tcb-for-fmspc
branch
from
cfd76dc
to
726bb76
Compare
cbeck88
reviewed
May 16, 2023
cbeck88
approved these changes
May 16, 2023
The `Advisories` corresponding to a given TCB can now be retrieved from the `TcbInfo`.
nick-mobilecoin
force-pushed
the
nick/displayable-error-tree
branch
from
d0eca4a
to
a83bf08
Compare
nick-mobilecoin
force-pushed
the
nick/get-tcb-for-fmspc
branch
from
726bb76
to
a41235f
Compare
Merged
Previously `TcbInfo::advisories()` would return an `Option`. Now `TcbInfo::advisories()` returns a `Result<>` with dedicated errors for mismatched FMSPC and unsupported TCB level.
This was referenced May 19, 2023
nick-mobilecoin
added a commit
to mobilecoinfoundation/sgx
that referenced
this pull request
May 22, 2023
Previously the only way to construct a `TcbInfo` was via the `TryFrom` trait. Now a `new()` method is available for creating a `TcbInfo`. While working on mobilecoinfoundation/attestation#89 it became apparent that not being able to easily construct a `TcbInfo` type would be difficult to test the behavior of finding the correct advisories for a given TCB
This was referenced May 23, 2023
|
@nick-mobilecoin started a stack merge that includes this pull request via Graphite. |
|
@nick-mobilecoin merged this pull request with Graphite. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Advisoriescorresponding to a given TCB can now be retrieved fromthe
TcbInfo.Motivation