Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move common types to lib.rs #86

Merged
merged 1 commit into from
May 16, 2023
Merged

Conversation

nick-mobilecoin
Copy link
Collaborator

Move the following generic types and traits from report_body.rs to
lib.rs:

  • EqualityVerifier
  • GreaterThanEqualVerifier
  • Accessor
  • IntoVerificationError

This move allows for other modules to make use of them.

Motivation

@meowblecoinbot meowblecoinbot requested review from a team, jcape and samdealy and removed request for a team May 11, 2023 17:10
@github-actions github-actions bot added the size/L Large PRs label May 11, 2023
@nick-mobilecoin nick-mobilecoin requested review from cbeck88 and removed request for jcape and samdealy May 11, 2023 17:10
@github-actions
Copy link

❌ Unreviewed dependencies found

Crate Version Reviews (N/2) LoC Left-Pad Index Geiger Flags

@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Merging #86 (9ebad42) into nick/verify_tcb_signature (e604685) will increase coverage by 0.01%.
The diff coverage is 95.55%.

@@                      Coverage Diff                      @@
##           nick/verify_tcb_signature      #86      +/-   ##
=============================================================
+ Coverage                      97.79%   97.80%   +0.01%     
=============================================================
  Files                              7        7              
  Lines                           1810     1819       +9     
=============================================================
+ Hits                            1770     1779       +9     
  Misses                            40       40              
Impacted Files Coverage Δ
verifier/src/lib.rs 90.83% <93.93%> (+0.31%) ⬆️
verifier/src/report_body.rs 99.69% <100.00%> (+0.28%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Move the following generic types and traits from `report_body.rs` to
`lib.rs`:

- `EqualityVerifier`
- `GreaterThanEqualVerifier`
- `Accessor`
- `IntoVerificationError`

This move allows for other modules to make use of them.
Base automatically changed from nick/verify_tcb_signature to main May 16, 2023 22:54
@nick-mobilecoin nick-mobilecoin merged commit 75485e8 into main May 16, 2023
24 of 25 checks passed
@nick-mobilecoin nick-mobilecoin deleted the nick/move-common-types-to-lib branch May 16, 2023 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Large PRs
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants