-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move common types to lib.rs #86
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 11, 2023
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
❌ Unreviewed dependencies found
|
Codecov Report
@@ Coverage Diff @@
## nick/verify_tcb_signature #86 +/- ##
=============================================================
+ Coverage 97.79% 97.80% +0.01%
=============================================================
Files 7 7
Lines 1810 1819 +9
=============================================================
+ Hits 1770 1779 +9
Misses 40 40
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This was referenced May 11, 2023
5ce40ff
to
0101294
Compare
07a9e05
to
f316ffb
Compare
cbeck88
approved these changes
May 12, 2023
Move the following generic types and traits from `report_body.rs` to `lib.rs`: - `EqualityVerifier` - `GreaterThanEqualVerifier` - `Accessor` - `IntoVerificationError` This move allows for other modules to make use of them.
f316ffb
to
9ebad42
Compare
This was referenced May 15, 2023
Merged
This was referenced May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the following generic types and traits from
report_body.rs
tolib.rs
:EqualityVerifier
GreaterThanEqualVerifier
Accessor
IntoVerificationError
This move allows for other modules to make use of them.
Motivation