-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CRL logic to certificate verification #94
Conversation
The [`UnverifiedCertificateChain::verify`] method now takes a list of CRLs to check for revoked certificates.
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
❌ Unreviewed dependencies found
|
Codecov Report
@@ Coverage Diff @@
## nick/remove-alternate-cert-logic #94 +/- ##
====================================================================
+ Coverage 97.63% 97.81% +0.17%
====================================================================
Files 6 6
Lines 1736 1919 +183
====================================================================
+ Hits 1695 1877 +182
- Misses 41 42 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Previously the x509 types were using multiple `try_from()` implementations. This made it implicit if the user was converting from a PEM or a DER version, but it also made it more likely that someone might inadvertently do `pem.as_bytes()` and have a failure trying to decode the data as DER when in fact it was pem data. Now the dedicated methods ensure the explicit types.
@nick-mobilecoin started a stack merge that includes this pull request via Graphite. |
@nick-mobilecoin merged this pull request with Graphite. |
The [
UnverifiedCertificateChain::verify
] method now takes a list ofCRLs to check for revoked certificates.
Motivation