Remove mc-crypto-dalek #3282
Merged
Remove mc-crypto-dalek #3282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 24, 2023
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
jcape
approved these changes
Mar 24, 2023
jcape
requested review from
a team and
nick-mobilecoin
and removed request for
a team
nick-mobilecoin
approved these changes
Mar 24, 2023
samdealy
force-pushed
the
sam/curve-4.0.0-rc.1
branch
from
7384d5e
to
d790e3e
Compare
samdealy
force-pushed
the
sam/remove-mc-crypto-dalek
branch
2 times, most recently
from
058d6f0
to
7b4eab9
Compare
samdealy
force-pushed
the
sam/curve-4.0.0-rc.1
branch
from
3337897
to
56adf16
Compare
samdealy
force-pushed
the
sam/remove-mc-crypto-dalek
branch
from
7b4eab9
to
07c8cc1
Compare
cbeck88
approved these changes
Mar 25, 2023
samdealy
force-pushed
the
sam/remove-mc-crypto-dalek
branch
from
07c8cc1
to
d3550e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Now that we are setting feature flags using rustc flags, it doesn't make sense to use mc-crypto-dalek, which was created in order to centralize feature selection for dalek crates.