Refactor logic for generating sim files in mc-attest-verifier
#3495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logic for (re)generating sim files has been re-worked to make it easier to add the generation of more sim files.
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
nick-mobilecoin
commented
Aug 11, 2023
nick-mobilecoin
commented
Aug 11, 2023
This was referenced Aug 11, 2023
eranrund
reviewed
Aug 14, 2023
Previously a signal file was used to indicate a regeneration of the sime files was needed. Now the original logic of any file not existing causes the files to be re-generated.
nick-mobilecoin
commented
Aug 14, 2023
eranrund
approved these changes
Aug 14, 2023
Merged
|
@nick-mobilecoin started a stack merge that includes this pull request via Graphite. |
|
@nick-mobilecoin merged this pull request with Graphite. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic for (re)generating sim files has been re-worked to make it
easier to add the generation of more sim files.
This is smaller refactor to prepare for the need to generate more sim files.