Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unfork and update Prost #898

Merged
merged 1 commit into from
Sep 8, 2021
Merged

Unfork and update Prost #898

merged 1 commit into from
Sep 8, 2021

Conversation

jcape
Copy link
Contributor

@jcape jcape commented Sep 8, 2021

Motivation

Reducing the number of forks which our code depends on is an unqualified good.

In this PR

  • Remove crates.io patches.
  • Update prost to 0.8.
  • Adjust repr-bytes usage to handle bytes 1.0 API changes.

@jcape jcape added this to the Build on M1 milestone Sep 8, 2021
@jcape jcape requested review from a team September 8, 2021 20:39
@jcape jcape self-assigned this Sep 8, 2021
@jcape jcape removed this from the Build on M1 milestone Sep 8, 2021
@jcape jcape marked this pull request as ready for review September 8, 2021 21:22
eranrund
eranrund approved these changes Sep 8, 2021
View reviewed changes
Copy link
Contributor

@eranrund eranrund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

cbeck88
cbeck88 approved these changes Sep 8, 2021
View reviewed changes
Copy link
Contributor

@cbeck88 cbeck88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@jcape jcape merged commit c782aa3 into mobilecoinfoundation:master Sep 8, 2021
@jcape jcape deleted the feature/prost-0.6-unfork branch September 8, 2021 22:13
@jcape jcape mentioned this pull request Sep 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbeck88 cbeck88 cbeck88 approved these changes

@eranrund eranrund eranrund approved these changes

@mfaulk mfaulk mfaulk approved these changes

@christian-oudard christian-oudard christian-oudard approved these changes

Assignees

@jcape jcape

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jcape @christian-oudard @mfaulk @eranrund @cbeck88