Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payloads field type error #21

Closed
pagetable opened this issue Aug 6, 2019 · 1 comment · Fixed by #24
Closed

Payloads field type error #21

pagetable opened this issue Aug 6, 2019 · 1 comment · Fixed by #24
Labels
bug Something isn't working

Comments

@pagetable
Copy link

Although Type hints are not utilized in this project yet, I found some potential errors in the field type of payloads. I have double checked all these field types with json shcemas.

call.py

  • GetConfigurationPayload.key: str -> List
  • RemoteStartTransactionPayload.id_tag: int -> str
  • MeterValuesPayload.connector_id: str -> int
    MeterValuesPayload.meter_value: Dict -> List
    MeterValuesPayload.transaction_id: str -> int
  • StopTransactionPayload.transaction_data: Dict -> List

call_result.py

  • GetConfigurationPayload.configuration_key: Dict -> List
    GetConfigurationPayload.unknown_key: str -> List

If these are wrong, please just ignore my issue. Thanks.

@OrangeTux
Copy link
Collaborator

Thank for reporting this issue! The problems will be fixed

@OrangeTux OrangeTux added the bug Something isn't working label Aug 6, 2019
OrangeTux pushed a commit that referenced this issue Aug 27, 2019
OrangeTux pushed a commit that referenced this issue Aug 27, 2019
OrangeTux added a commit that referenced this issue Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging a pull request may close this issue.

2 participants